Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update .editorconfig #287

Merged
merged 1 commit into from
Sep 30, 2021
Merged

Update .editorconfig #287

merged 1 commit into from
Sep 30, 2021

Conversation

cw789
Copy link
Contributor

@cw789 cw789 commented Sep 29, 2021

Probably bikeshedding (resorting things).

But with tab the indent_size should be an user preference. (we have mixed source files)
Additionally added .md for possibly future guides with this extension.
Removed .conf as nowhere seen in this repository.
Changed the indent_size to 2 for .yml (as it is currently used).

@mworrell
Copy link
Collaborator

I am not sure about the tab change.

We might have mixed source files, and sometimes a combination of spaces and tabs is used for alignment.

@cw789
Copy link
Contributor Author

cw789 commented Sep 30, 2021

Your're right. With the existing mixed source files it's better to keep the pre configured ident_size for the tabs.
Otherwise it makes the code less readable for users with different configured tab size (provided they use an .editorconfig compatible editor - otherwise it's anyway disordered).

So I've reverted the change.

It's now only resorting some things in the file.
Adding .md as extension (for future guides I possibly will write).
Removing .conf as I don't find an extension like that in the repository.

So close or merge. I'm happy with both.

Copy link
Collaborator

@seriyps seriyps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, unfortunately the coding style we have in gen_smtp is quite special =)
It would be cool to add some code-formatter like https://github.com/WhatsApp/erlfmt one day, but the problem with it is that it messes-up with the git blame...

@cw789
Copy link
Contributor Author

cw789 commented Sep 30, 2021

Ok, I did one last quick edit.
I changed the ident_size to 2 for .yml as it is currently in there.

@mworrell
Copy link
Collaborator

@cw789 is this ready for merge?

@cw789
Copy link
Contributor Author

cw789 commented Sep 30, 2021

@cw789 is this ready for merge?

Yes it is now.

@mworrell mworrell merged commit 053b228 into gen-smtp:master Sep 30, 2021
@mworrell
Copy link
Collaborator

Thanks!

@cw789 cw789 deleted the editorconfig branch September 30, 2021 15:05
@cw789
Copy link
Contributor Author

cw789 commented Oct 1, 2021

Yep, unfortunately the coding style we have in gen_smtp is quite special =)
It would be cool to add some code-formatter like https://github.com/WhatsApp/erlfmt one day, but the problem with it is that it messes-up with the git blame...

Possibly sometime an evaluation worth. But the thing with git blame is a good point. Wouldn't have thought about that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants