rename SetTraceLog to SetTraceLogLevel #276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you please fix the comment as well? We usually have the function name inside the comment. Someone must have forgotten that too. // SetTraceLogLevel - Set the current threshold (minimum) log level
func SetTraceLogLevel(logLevel TraceLogLevel) {Don't know exactly why, but found this explanation: |
|
I have updated the comments for both SetTraceLogLevel and TraceLog |
|
Merged, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The C function in raylib is SetTraceLogLevel but in the go binding is SetTraceLog. I found this annoying so I have opened a pull request to fix it. If you want me to add other functions with the old name as well for backwards compatibility let me know. I just think that the Go API should match the C api. If you don't want to change this that's fine, then just close this PR.