Partial Fix For Source Generated Queries #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed. This is because the cached `Query` object will be used with the wrong `World`, leading to bad query results. This fixes that by storing which world the cache is relevant for. This is only a partial fix, the cache is still broken in the case of multithreaded access.
|
Some discussion on this issue (including another potential fix) in discord, starting here: https://discord.com/channels/1099813114876284928/1100418566706171974/1179232143830945842 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Source generated queries are unusable if multiple worlds are being used. This is because the cached
Queryobject will be used with the wrongWorld, leading to bad query results. See #54This fixes that by storing which world the cache is relevant for.
This is only a partial fix. If multiple worlds are being used with multithreading then the cache may be made invalid by another thread while it's in use.