Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix of Dangerous SetChunk. Chunks should be rented #212

Merged
merged 1 commit into from
Apr 16, 2024

Conversation

ArhinZi
Copy link
Contributor

@ArhinZi ArhinZi commented Mar 30, 2024

No description provided.

@genaray genaray added the enhancement New feature or request label Apr 8, 2024
@genaray
Copy link
Owner

genaray commented Apr 8, 2024

Thanks! Could you probably add an explanation? :)

@ArhinZi
Copy link
Contributor Author

ArhinZi commented Apr 9, 2024

@genaray
after i deserialized world. It is not Rented now, so can`t return. So not renting chunks on deserialization causes proplems when Arch wants to EnsureCapacity
image

@maidopi-usagi
Copy link

@genaray after i deserialized world. It is not Rented now, so can`t return. So not renting chunks on deserialization causes proplems when Arch wants to EnsureCapacity 在我反序列化世界之后。现在不是租的,所以不能回来。因此,当 Arch 想要 EnsureCapacity 时,在反序列化时不租用块会导致出现问题 image

can confirm that the same problem exists here, after a new world being deserialized and adding several entities into this new world will throw out this exception(when the amount reaches the capacity of last chunk ).

@genaray genaray merged commit b434352 into genaray:master Apr 16, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants