Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Connection to private channels #2

Merged
merged 1 commit into from
Apr 25, 2018
Merged

Connection to private channels #2

merged 1 commit into from
Apr 25, 2018

Conversation

genaromadrid
Copy link
Owner

No description provided.

@genaromadrid genaromadrid merged commit 2944b23 into develop Apr 25, 2018
@coveralls
Copy link

coveralls commented Apr 25, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 22

  • 16 of 39 (41.03%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-8.7%) to 56.098%
Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/em/pusher/client/msg_parser.rb 7 9 77.78%
lib/em/pusher/client.rb 2 7 28.57%
lib/em/pusher/client/connection.rb 7 23 30.43%
Totals Coverage Status
Change from base Build 19: -8.7%
Covered Lines: 69
Relevant Lines: 123
💛 - Coveralls

@genaromadrid genaromadrid deleted the feature/private-channels branch April 25, 2018 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@genaromadrid @coveralls