Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

got versioning issues #48

Closed
jscook opened this issue Mar 15, 2015 · 3 comments
Closed

got versioning issues #48

jscook opened this issue Mar 15, 2015 · 3 comments

Comments

@jscook
Copy link

jscook commented Mar 15, 2015

  • $ got help

does not list 'version' as an available command

  • $ got version

reports what I expect

  • $ got --version

does not report what I expect:

jsc@luskan Documents % got --version
/Users/jsc/.plenv/versions/5.20.1/bin/got
(Getopt::Long::GetOptions version 2.42; Perl version 5.20.1)

@genehack
Copy link
Owner

So, I can confirm 'version' does not appear in 'got help'. I'll try to figure out why that is.

However, I can not confirm the differing version numbers, and I suspect you may have dueling Got versions installed, maybe?

% got version
1.23

% got --version
got (App::GitGot) version 1.23 (/opt/plenv/versions/5.20.2/bin/got)

@jscook
Copy link
Author

jscook commented Mar 16, 2015

Sorry. That was from the previous version I had installed (1.22). The TRIAL version reports both versions correctly.

@genehack
Copy link
Owner

So, I've removed my local version subcommand lib. That means the version subcommand shipped with App::Cmd will handle both got version and got --version, so you'll see the same thing for both (once v1.24 is released).

I've also opened an issue over in App::Cmd land to see if there's any way to get the version command included in the command list -- right now, it's just stripped out, and there's no good way to override that behavior. That will be discussed here -> rjbs/App-Cmd#45

genehack added a commit that referenced this issue Mar 16, 2015
App::Cmd provides one automatically.
genehack added a commit that referenced this issue Mar 16, 2015
  * Update copyright to 2015 (John Anderson)
  * Lock Net::GitHub to at least v0.74 [#47] (John Anderson)
  * Various testing improvements (John Anderson)
  * Turn off IO::Page in 'got all' (John Anderson)
  * Get rid of Term::Readline in favor of IO::Prompt::Simple (John Anderson)
  * Move towards using Path::Tiny for errything (John Anderson)
  * Whitespace cleanup (John Anderson)
  * Clean up 'use' stanzas (John Anderson)
  * delete 'version' command [#48] (John Anderson)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants