migrate from Test::More to Test2::V0 #72
Conversation
| @@ -45,7 +45,7 @@ $ENV{GITGOT_FAKE_GIT_WRAPPER} = 1; | |||
| my $entry = LoadFile( $config ); | |||
| is( $entry->[0]{name} , 'fake-git-repo' , 'expected name' ); | |||
| is( $entry->[0]{type} , 'git' , 'expected type' ); | |||
| is( $entry->[0]{path} , path( "$dir/fake-git-repo" ) , 'expected path' ); | |||
| is( $entry->[0]{path} , ''.path( "$dir/fake-git-repo" ) , 'expected path' ); | |||
There was a problem hiding this comment.
Why is the "append to an empty string" bit needed?
There was a problem hiding this comment.
path is a Path::tiny object, and is won't auto-overload it into its string representation iirc.
There was a problem hiding this comment.
There is ->stringify if you want a more couth version
There was a problem hiding this comment.
|
So, I don't see the point of converting to What am I missing? |
6 lines. New commit pushed. |
|
So, yeah, if this is going to end up adding additional testing code that I have to maintain going forward, I'm not interested. It's one thing if it's just swapping one dep for another and changing some function call signatures; maintaining extra code that is maintained for me today is not an improvement in my book. |
As My Life with the Thrill Test Kult would say
I am the new way to Test2::V0
I am the way of the future
(seriously, this PR is mostly for giggles, and because if we don't promote and lead the way to Perl evolution, who else will?)