added tests for ar

lib/apt-repo.js

@@ -10,6 +10,10 @@ var gpg = require('./gpg');
 
 var ARCHITECTURES = exports.ARCHITECTURES = ['i386', 'amd64', 'all'];
 
+//process.on('uncaughtException', function(err) {
+//  console.log(err);
+//});
+
 if (!fs.existsSync('./tmp/')) {
 	fs.mkdirSync('./tmp/'); 
 }

lib/ar.js

@@ -37,8 +37,9 @@ exports.extractFile = function(ar_file, packed_file) {
 	    	return error;
 	    }
 		var offset = AR_HEADER_LENGTH;
-	    while (true) {
-		    fs.readSync(fd, buffer_header, 0, AR_FILE_HEADER_LENGTH, offset);
+		var bytesRead = 1;
+	    while (bytesRead > 0) {
+		    bytesRead = fs.readSync(fd, buffer_header, 0, AR_FILE_HEADER_LENGTH, offset);
 
 			var fileheader = buffer_header.toString();
 			var filename = fileheader.substr(0, 16).trim() // see header for magic numbers

package.json

@@ -9,7 +9,8 @@
     "url": "git://github.com/genehallman/node-apt-repo.git"
   },
   "scripts": {
-    "start": "node ./lib/apt-repo"
+    "start": "node ./lib/apt-repo",
+    "test": "./node_modules/.bin/mocha --ui exports tests/*.test.js --reporter spec"
   },
   "dependencies": {
     "tar": ">=0.1.14",
@@ -21,5 +22,9 @@
   },
   "engines": {
     "node": ">=0.6.0"
+  },
+  "devDependencies": {
+    "mocha": "*",
+    "should": "*"
   }
 }

tests/ar.test.js

@@ -0,0 +1,36 @@
+var ar = require('../lib/ar');
+var should = require('should');
+
+module.exports = {
+
+  'test .extractFile() when packed file exists': function(done) {
+    var fileContents = ar.extractFile("tests/fixtures/test.ar", "test_file.txt");
+    fileContents.constructor.should.equal(Buffer);
+    fileContents.toString().should.equal('this is a test\n');
+    done();
+  },
+
+  'test .extractFile() when packed file doesnt exist': function(done) {
+    var fileContents = ar.extractFile("tests/fixtures/test.ar", "test_file2.txt");
+    fileContents.constructor.should.equal(Object);
+    fileContents.status.should.equal('error');
+    fileContents.message.should.equal('Packed file not found');
+    done();
+  },
+
+  'test .extractFile() when archive file doesnt exist': function(done) {
+    (function(){
+      ar.extractFile("nonexistant.ar", "test_file2.txt");
+    }).should.throw()
+    done();
+  },
+
+  'test .extractFile() when archive file is broken': function(done) {
+    var fileContents = ar.extractFile("tests/fixtures/broken.ar", "test_file.txt");
+    fileContents.constructor.should.equal(Object);
+    fileContents.status.should.equal('error');
+    fileContents.message.should.equal('Missing file header');
+    done();    
+  }
+
+};

tests/fixtures/broken.ar

@@ -0,0 +1 @@
+this is not a very good archive

tests/fixtures/test.ar

@@ -0,0 +1,4 @@
+!<arch>
+test_file.txt   1363128337  501   20    100644  15        `
+this is a test
+