add ui template for ctl #660
Conversation
Alexanderlacuna
force-pushed
the
feature/gn3-ctl
branch
from
bdf1d94
to
568872e
Compare
|
@BonfaceKilz thanks for the review, need to work on the naming of my variables in general.Will ping you when I fix the above. |
|
plus before merge, will set things up for @robwwilliams @zsloan to test this on penguin and give their feedback |
|
Alexander Kabui ***@***.***>
anaandika:
@BonfaceKilz thanks for the review, need to work on the naming of my variables in general.Will ping you when I fix the above.
Sure!
|
|
+1
|
Alexanderlacuna
force-pushed
the
feature/gn3-ctl
branch
from
568872e
to
f5baaf5
Compare
There was a problem hiding this comment.
LGTM. @Alexanderlacuna should I go ahead and merge this? You can address minor issues in another PR.
| def parse_geno_data(dataset_group_name) -> dict: | ||
| """ | ||
| Args: | ||
| dataset_group_name: string name |
There was a problem hiding this comment.
nitpick: Args should be more descriptive. And types captures what you've documented as an arg:
def parse_geno_data(dataset_group_name -> str) -> dict:
...
I think I'll have to look for resources to point you to show you how to improve documentation. @arunisaac if you have anything in mind, you could share ;)
| """function to make an api call | ||
| to gn3 and run ctl""" |
There was a problem hiding this comment.
nitpick: We already know this is a function.
| """function to make an api call | |
| to gn3 and run ctl""" | |
| """Make an api call to gn3 and run ctl""" |
|
I think I'll have to look for resources to point you to show you how
to improve documentation. @arunisaac if you have anything in mind,
you could share ;)
I haven't really thought much about docstrings, and don't have any
resources in mind at the moment. I'm hoping you will come up with
something, Bonface! :-)
|
|
Arun Isaac ***@***.***> anaandika:
> I think I'll have to look for resources to point you to show you how
> to improve documentation. @arunisaac if you have anything in mind,
> you could share ;)
I haven't really thought much about docstrings, and don't have any
resources in mind at the moment. I'm hoping you will come up with
something, Bonface! :-)
Cool. That's one of the things I want improved
with how we code. Standard ways of documenting
things.
…--
Bonface M. K.
D4F09EB110177E03C28E2FE1F5BBAE1E0392253F (hkp://keys.gnupg.net)
Free Software Activist
Humble GNU Emacs User | Bearer of scheme-y parens
Curator: <https://upbookclub.com> | Twitter: @BonfaceKilz
|
|
@BonfaceKilz This is can be merged |
Description
This PR integrate to gn3 ctl and making the required plots
How should this be tested?
Any background context you want to provide?
What are the relevant pivotal tracker stories?
Screenshots (if appropriate)
Questions