Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

term name sometimes does not appear #495

Closed
ValWood opened this issue May 2, 2018 · 10 comments
Closed

term name sometimes does not appear #495

ValWood opened this issue May 2, 2018 · 10 comments

Comments

@ValWood
Copy link

ValWood commented May 2, 2018

see
http://amigo.geneontology.org/amigo/gene_product/PomBase:SPCC162.08c

GO:0005487

obsolete

maybe it is obsolete? but in that case it isn't very clear when you click on it....
http://amigo.geneontology.org/amigo/term/GO:0005487

@pgaudet
Copy link

pgaudet commented May 2, 2018

It is the secondary ID of GO:0017056.
The mapping should happen automatically...?

@kltm kltm added the question label May 2, 2018
@kltm
Copy link
Member

kltm commented May 2, 2018

It looks like it was replaced by GO:0017056; this smacks of an upstream data problem--I had thought that there was automatic replacement in the pipeline in these cases. @dougli1sqrd , do you know if this actually occurs, or is it just in my head?

@pgaudet
Copy link

pgaudet commented May 3, 2018

@kltm @cmungall @dougli1sqrd

if it occurs- where would that be documented ?
According to this, the rule exists:
https://github.com/geneontology/go-site/blob/master/metadata/rules/gorule-0000020.md

but it says it's a 'soft check'; is this correct ? shouldn't it be a 'replace' script?

TO DO: It would be nice if each rule page pointed to the error report.

Thanks, Pascale

@kltm
Copy link
Member

kltm commented May 3, 2018

@dougli1sqrd Can you confirm this one way or another, so we know where the upstream issue is and can move this out of the AmiGO tracker?

@pgaudet if you have a TODO, it should be opened in the proper tracker.

@pgaudet
Copy link

pgaudet commented May 4, 2018

@kltm Thanks ! moved my todo here: geneontology/go-annotation#1928

@kltm
Copy link
Member

kltm commented May 25, 2018

At least in this case, this has been cleared. This is/was likely an upstream data issue.

@kltm kltm closed this as completed May 25, 2018
@kltm
Copy link
Member

kltm commented May 25, 2018

@kltm kltm reopened this May 25, 2018
@pgaudet
Copy link

pgaudet commented May 28, 2018

AFAIK this is the case for many merged terms.

@kltm
Copy link
Member

kltm commented Jun 29, 2018

@dougli1sqrd Is there currently not an upgrade step running in the GAF processing pipeline?

@pgaudet
Copy link

pgaudet commented Sep 28, 2018

Fixed, thanks !!!!!!

@pgaudet pgaudet closed this as completed Sep 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants