Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

geneontology.github.io URL exposed in many cases where a "/" is not included at the end of the URL #369

Open
suzialeksander opened this issue Aug 23, 2022 · 5 comments

Comments

@suzialeksander
Copy link
Collaborator

I think this is unintentional, but trying to provide a user with a link to

geneontology.org/docs/downloads#doi-versioned-bundles

displays the address of

https://geneontology.github.io/docs/downloads/#doi-versioned-bundles

I think we wanted the .github.io bits hidden?? On FF 98.x

@kltm

@suzialeksander
Copy link
Collaborator Author

suzialeksander commented Aug 23, 2022

This might also have something to do with having been sent to the /downloads page from our search but I cannot reproduce

@kltm
Copy link
Member

kltm commented Aug 24, 2022 via email

@kltm kltm changed the title geneontology.github.io/docs URL exposed geneontology.github.io URL exposed in many cases where a "/" is not included at the end of the URL Nov 3, 2022
@kltm
Copy link
Member

kltm commented Nov 3, 2022

Looking into this a little more.
Basically, our proxy asks for a page, GH says "sure, found it" and sends a 301 redirect to the GH location, which the browser then follows.
We would be able to get around this by doing one of the following:

  1. Going all in on GH as our root domain (some peripheral outstanding problems w/going this way)
  2. Make the proxy smarter so that the rewrite with the slash is made at our end, never giving GH a chance to do the wrong thing.
  3. Try and get GH to do the right thing; not sure if possible yet
    If this is an issue, 2 is probably the fastest out the door.

@kltm
Copy link
Member

kltm commented Nov 3, 2022

@suzialeksander Noting that http://geneontology.org/docs/downloads/#doi-versioned-bundles does not have the forwarding issue as the URL has the slash that GH Pages likes at the end.

@suzialeksander
Copy link
Collaborator Author

to add, no external group/user has ever complained or noticed, so door 2 seems to be a good solution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants