Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review annotations to 'GO:0000988 transcription factor activity, protein binding' and similar children #2024

Closed
pgaudet opened this issue Jul 11, 2018 · 21 comments

Comments

@pgaudet
Copy link
Contributor

pgaudet commented Jul 11, 2018

Hello,

From the annotation call of July 10, 2018, I propose to obsolete 'transcription factor activity, protein binding' and similar children. The list of terms is in the ontology ticket
geneontology/go-ontology#16053

Annotations and potential replacements for many of them are here: https://docs.google.com/spreadsheets/d/1jwgpZF3paxNOHvEHQ4v_uxOFb3FjQUOnxSJpswIzyMI/edit#gid=0

Annotation guidelines are here: https://goo.gl/dsvB18

Groups impacted | Number of annotations
BHF-UCL | 28 @RLovering - done
CACAO | 1 @sandyl27
CAFA | 11 @ggeorghiou
ComplexPortal | 3 @bmeldal
FlyBase | 21 @hattrill
MGI | 19 @hdrabkin
ParkinsonsUK-UCL | 1 @RLovering - done
PomBase | 2 @ValWood
SGD | 77 @srengel @krchristie
TAIR | 1 @tberardini
UniProt | 3 @ggeorghiou
WB | 7 @vanaukenk
ZFIN | 4 @sabrinatoro

Thanks, Pascale

@sabrinatoro
Copy link

What should I do with the following annotation?
Kctd10 was shown to bind to Tbx5a (which was shown to be a transcription factor), and this binding repress the transcriptional activity of Tbx5a.
There is no report of Kctd10 binding to DNA, and no report that it is binding to RNA polymerase II basal transcription machinery.
How should Kctd10 be annotated?
Thank you!

@tberardini tberardini removed their assignment Jul 12, 2018
@pgaudet
Copy link
Contributor Author

pgaudet commented Jul 12, 2018

Hi @sabrinatoro
I would annotate to GO:0003714 transcription corepressor activity. (Note that this term needs to be reviewed too, but I am pretty sure that Kctd10 would be correctly annotated there.)

Thanks, Pascale

@pgarmiri pgarmiri self-assigned this Jul 12, 2018
@pgaudet
Copy link
Contributor Author

pgaudet commented Jul 12, 2018

NOTE: I restored GO:0003711 transcription elongation regulator activity
which should allow to annotate some proteins in that list (See geneontology/go-ontology#14398)

@pgarmiri
Copy link

The UniProt annotations have been reviewed and updated.

@pgarmiri pgarmiri removed their assignment Jul 12, 2018
@bmeldal
Copy link

bmeldal commented Jul 12, 2018

All complexes changed. All TFs with to-be-obsoleted terms now have annotations to GO:0140110 transcription regulator activity or children. However, as the term is new I doubt all TFs in the Complex Portal are annotated with this branch... I'd have to do some archaeology to fix that!

@bmeldal bmeldal assigned pgarmiri and unassigned bmeldal Jul 12, 2018
@sandyl27
Copy link

CACAOs annotation has been updated.

@sandyl27 sandyl27 removed their assignment Jul 12, 2018
@sabrinatoro
Copy link

Thank you @pgaudet.
The ZFIN annotations have been reviewed and updated.

@sabrinatoro sabrinatoro removed their assignment Jul 12, 2018
@ValWood ValWood removed their assignment Jul 13, 2018
@ValWood
Copy link
Contributor

ValWood commented Jul 13, 2018

I have no annotations to GO:0000988 so I must have done them in a previous round.

@pgarmiri pgarmiri removed their assignment Jul 13, 2018
@pgaudet
Copy link
Contributor Author

pgaudet commented Jul 13, 2018

@ValWood It's very possible that you already deleted the annotations, but in the spreadsheet you still have two proteins (PomBase:SPBC2D10.06; PomBase:SPBC2F12.11c)
Can you go in the google spreadsheet and mark those proteins as fixed ?
https://docs.google.com/spreadsheets/d/1jwgpZF3paxNOHvEHQ4v_uxOFb3FjQUOnxSJpswIzyMI/edit#gid=0

@tberardini
Copy link

TAIR done.

@ValWood
Copy link
Contributor

ValWood commented Jul 13, 2018

done ;)

@pgaudet pgaudet changed the title Review annotations to 'GO:0000988 transcription factor activity, protein binding' and similarchildren Review annotations to 'GO:0000988 transcription factor activity, protein binding' and similar children Jul 15, 2018
@vanaukenk
Copy link
Contributor

WB annotations reviewed and updated.

@vanaukenk vanaukenk removed their assignment Jul 16, 2018
@pgaudet
Copy link
Contributor Author

pgaudet commented Jul 26, 2018

@srengel @suzialeksander
Would it be OK if I went ahead with the obsoletion tomorrow, so that it appears in the next release ? (Otherwise further changes are more difficult).

That might mean you have annotations to obsolete terms but that should be for a short period until you get to fixing them.

Thanks, Pascale

@srengel
Copy link

srengel commented Jul 26, 2018

That’s ok. I won’t be able to get to these until next week, but will get it done then.

@hdrabkin
Copy link

By the spreadsheet, any annotations left to mouse genes have been done by BHF-UCL or ParkinsonsUK-UCL; MGI can't do anything to those as they are dropped and re-loaded weekly. So I'll take my name off of the assigned.

@hdrabkin hdrabkin removed their assignment Jul 26, 2018
@RLovering
Copy link

RLovering commented Jul 29, 2018

Ok BHF annotations done, but I couldn't see the Parkinson's annotation in the table, Im sure it was there before - Ruth

@RLovering RLovering removed their assignment Jul 29, 2018
@pgaudet
Copy link
Contributor Author

pgaudet commented Jul 30, 2018

@RLovering
There were filters applied. There is 1 Parkinson's annotation to UniProtKB:P18848

Thanks, Pascale

@RLovering
Copy link

thanks sorted out that last one. I did try to select all in the filter option, maybe I just had slow internet
Ruth

@pgaudet
Copy link
Contributor Author

pgaudet commented Nov 19, 2018

Closing this. Some groups have not responded
@hdrabkin @hattrill @pgarmiri

but the term has already been obsoleted.

@pgaudet pgaudet closed this as completed Nov 19, 2018
@pgarmiri
Copy link

The UniProt annotations have been reviewed and updated.

@pgaudet I had another look at the spreadsheet. There is only one annotation from UniProt left but is ISS, so this should have been fixed automatically after the parent was corrected.
Thanks

@RLovering
Copy link

Hi Pascale

in ticket https://docs.google.com/spreadsheets/d/1uHMSFAuxsOL54F0CLiB2lbrYyvjHTbyA0O2n8rsgKEI/edit#gid=0 you list BHF annotations as not done for this ticket, but they are done it is just I hadn't marked them as done. I have highlighted them on the ticket.

Ruth

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests