Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review annotations to "coenzyme" grouping terms #2927

Closed
krchristie opened this issue Apr 7, 2020 · 12 comments
Closed

Review annotations to "coenzyme" grouping terms #2927

krchristie opened this issue Apr 7, 2020 · 12 comments

Comments

@krchristie
Copy link

krchristie commented Apr 7, 2020

We are planning to obsolete all of the cofactor grouping terms, see geneontology/go-ontology#19243 for explanation.

I've included sequence based annotations to make sure the manual sequence annotations are reviewed, though I know some are from loads based on orthology with other sequences. If it will be fixed once the original annotation is fixed, you can just put a comment in the first column.

https://docs.google.com/spreadsheets/d/12A4Xlg907tiz3LApJ3NT9BcLWF5BOjg0wYwER4P_AO8/edit?usp=sharing

Direct annotations to coenzyme terms - Evidence by Contributor

Contributor IDA IGI IMP IPI TAS RCA ISM ISO ISS Grand Total
UniProt 4   1 2         12 19
RGD 2     2       6   10
MGI 1             8   9
AspGD 1         6       7
Reactome         6         6
JCVI                 4 4
MTBBASE 1   3             4
PseudoCAP     4             4
CAFA 2                 2
EcoCyc 1 1               2
GeneDB             1     1
TIGR                 1 1
Grand Total 12 1 8 4 6 6 1 14 17 69
@krchristie
Copy link
Author

krchristie commented Apr 7, 2020

@pgarmiri - Could you please look at the JCVI, MTBBASE, CAFA, & TIGR ones as well as the UniProt ones. Many thanks!

@krchristie
Copy link
Author

@brinkmanlab - Please review your annotations to any of the coenzyme terms and update to a more specific term if possible. Thanks very much.

@hdrabkin
Copy link

hdrabkin commented Apr 8, 2020

MGI done

@Achchuthan
Copy link

GeneDB done.

@deustp01
Copy link

deustp01 commented Apr 8, 2020

Reactome done - changes will become visible with June 2020 release.

A nomenclature issue: our pathway "Coenzyme A biosynthesis" was previously tagged with GO "coenzyme biosynthetic process" and that correctly tripped the alarm here. The fix is to re-tag the pathway with the GO term for Coenzyme A biosynthetic process, and to assert as a matter of nomenclature that "Coenzyme A" is a proper name that does not logically imply the role "coenzyme" or "cofactor". Elsewhere the same patch with the same nomenclatural wriggle was applied to our molybdenum cofactor metabolism pathway.

The fix is that where we used high-level "cofactor" and "coenzyme" terms to tag our high-level grouping pathways, those have been removed (we don't need them internally) and I've ensured that every child pathway that describes the metabolism of a specific molecule or family of them now has a metabolism process term that that points to the chemical type of the molecules, not to any alleged role they may have. (Even if those chemical names sometimes include a word like coenzyme)

@pgarmiri
Copy link

pgarmiri commented Apr 9, 2020

Hello,
Is it possible to have a term 'Coenzyme A binding'? There is GO:1905502
'acetyl-CoA binding' but it's not suitable for the case I am checking.

Thanks,
Penelope

@ValWood
Copy link
Contributor

ValWood commented Apr 9, 2020

This term is in many slims so maybe a broader announcement is needed.
v

@deustp01
Copy link

deustp01 commented Apr 9, 2020

This request seems OK because it's for a term to annotate the binding of a chemical whose (unfortunate) name is Coenzyme A - it's not annotating the coenzyme role.

@krchristie
Copy link
Author

Hello,
Is it possible to have a term 'Coenzyme A binding'? There is GO:1905502
'acetyl-CoA binding' but it's not suitable for the case I am checking.

Thanks,
Penelope

I agree with @deustp01 that a term for 'coenzyme A binding' is fine since that is binding to a specific compound.

@pgarmiri
Copy link

Hi,

All the relevant experimental annotations of UniProt-EBI and MTB have been checked by me. There were a couple more annotations (highlighted in orange background) that are referring to particular derivative compounds of Coenzyme A ( (3S)-3-hydroxy-3-methylglutaryl-CoA and succinyl-CoA) . Shall I request new binding terms for those?

@pgaudet checked most UniProt-SWIS annotations (there is one more left to be checked) and the JCVI ones.

The ISS annotations will be updated automatically when the parent annotations are all updated.

Thanks,

Penelope

@krchristie
Copy link
Author

Hi,

All the relevant experimental annotations of UniProt-EBI and MTB have been checked by me. There were a couple more annotations (highlighted in orange background) that are referring to particular derivative compounds of Coenzyme A ( (3S)-3-hydroxy-3-methylglutaryl-CoA and succinyl-CoA) . Shall I request new binding terms for those?

Requesting new terms seems like a good option to me, but I'll check with the ontology editor's group at our next Monday meeting (4/20/20) to confirm.

@pgaudet checked most UniProt-SWIS annotations (there is one more left to be checked) and the JCVI ones.

The ISS annotations will be updated automatically when the parent annotations are all updated.

Thanks,

Penelope

Thanks to you both.

@pgaudet
Copy link
Contributor

pgaudet commented May 12, 2020

I am closing this because the term was obsoleted already, so the remaining errors will appear in error reports.

For information
AspGD @marekskrzypek
RGD @gthayman
PseudoCAP @glwinsor

Still need to be fixed.

Thanks, Pascale
 

@pgaudet pgaudet closed this as completed May 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests