Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Box nesting for part_of #15

Closed
kltm opened this issue Feb 11, 2014 · 11 comments
Closed

Box nesting for part_of #15

kltm opened this issue Feb 11, 2014 · 11 comments

Comments

@kltm
Copy link
Member

kltm commented Feb 11, 2014

This will be a gather involved enhancement.
Should go after other refactors.

@kltm
Copy link
Member Author

kltm commented Feb 1, 2016

Hrm, I thought there was more here--I'm wondering if the discussion is hiding on another ticket (probably related to folding).

I believe the "strong" nested box model would be quite hard given the current framework.
Another option would be to build something around the folding system.

@kltm kltm added this to the wishlist milestone Feb 1, 2016
@cmungall
Copy link
Member

From email to list from Ruth:

Looking at Paul’s Wnt signaling LEGO model I do wonder if it would be possible to take the ‘Reactome’ type approach of circling (with shaded background?) some of the annotons to identify
those which belong to (are part of) large pathways, rather than simply having a part_of line between a pathway and 5-20+ annotons. I think the users will find this much easier to read.

@cmungall
Copy link
Member

the jsplumb docs mention 'containers', is this something different?

@kltm
Copy link
Member Author

kltm commented Feb 17, 2016

At the Caltech mini-meeting we talked about using the background canvas to give some of this effect, but I suspect that the reality would be rather underwhelming as it would require an uneasy balance between automatic and free layout.

We are also looking into what can be done with more complicated nodes and "folding".

I believe containers are something different from what is being described here.

@cmungall
Copy link
Member

cmungall commented Apr 8, 2016

Adding a mockup just to help people coming to this ticket orient

nestednedd4

Note that this shows containment within a continuant (nucleus, cell), by following occurs_in (and then part_of, once you are in the continuant hierarchy). I think the main requirement is to just do containment within the occurrent hierarchy (ie just following part-of). Thus the outermost box would be the overall pathway in many cases.

@kltm
Copy link
Member Author

kltm commented Apr 13, 2016

People coming in should also note that the final product is unlikely to look too much like this.

@kltm
Copy link
Member Author

kltm commented Apr 13, 2016

Although, I think that I might have thought of a cheat to simulate this (node points defining a dumb polygon). More exploration will be necessary; however, nesting boxes would have to exists entirely outside of the jsplumb and layout systems.

@kltm
Copy link
Member Author

kltm commented Jun 8, 2017

Also, maybe this could be accomplished with a workbench rather than in the "main" graph editor.

@goodb
Copy link

goodb commented Mar 21, 2018

Would be nice if this feature worked on has_part as well as part_of relations.

@kltm
Copy link
Member Author

kltm commented Mar 21, 2018

At this point, I think we need to give up with this for the main graph editor and figure out what we want for the "pathway" views, which can use the more malleable cytoscape.js (as demonstrated by the part-of boxing we can do there).
If there is no complaint, I'll reframe this ticket to add what @goodb wants in the pathway workbench.

@goodb
Copy link

goodb commented Mar 21, 2018

@kltm one alternative to consider might be to focus some team effort on an exporter designed to produce Cytoscape ingestible files. It most likely needs to be done anyway, gets the user immediate full access to all of their network layouts and analysis tools, and would allow for Web development time to focus on the editor ui. Does require the user to download Cytoscape though, don't know users well enough to know if thats a showstopper. (I could help with an exporter service if this was desirable.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants