-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NTR: GO term request with composed uberon terms #71
Comments
@cmungall Haven't figured out how to assign this to you. |
cc @dosumis I think generation of neurons should be the occurs in template (@cerivs - sorry, should have noticed this one, you can go ahead and add this now). E.g. 'generation of neurons' and occurs_in some hindbrain Are all your terms for cell types like 'hindbrain neuron', ie. cell types that have extrinsic differentia rather than intrinsic? You actually have two options with the existing templates for e.g. hindbrain neuron differentiation:
We don't really have any docs saying when to use which, we need this. My criteria would be:
If so, @cerivs is good to go? |
This is use 2, gota love researchers. There are many instances of zebrafish researchers saying a gene affects development of a cell type in a structure in a mutant. |
OK, I'm confident in saying you should go ahead and use the existing occurs_in template, I think you have permission. I'll leave this open til we discuss how best to document the choices here. Just curious, what does a line of your pheno.txt file look like for this? Maybe the GO annotation can be automated? |
We need to do a bit of work on the GO side: https://sourceforge.net/p/geneontology/ontology-requests/11756/ |
hindbrain interneuron - increased amount I could request subtypes for the hindbrain neuron development but these will get researchers to the right part of the brain. |
Need to request midbrain neuron development tree for completeness since it doesn't make sense to have forebrain neuron development in the GO but not midbrain or hindbrain. |
Hi @cerivs, do you have any references you could share for these? I think that generally the pattern should be:
GO then needs to leverage CL part/overlaps relationships to Uberon structure to make part relationships in GO. (This step is a general problem for GO). For the "hindbrain generation of neurons", we need to be careful:
|
I followed the pattern for forebrain neurons from GO. The paper I am curating GO for is PMID:9007241. We annotate phenotype and GO based on the author's statements in the pub so if they say hindbrain neurons are affected I am not going to say they aren't in the hindbrain. For what it is worth hindbrain starts at 10 somites in the ZFA and the fate mapping is widely accpeted. |
This is defined with reference to a CL term, as I suggested: forebrain neuron differentiation But it does also have the potentially dubious axiom: 'forebrain generation of neurons' does not have the axiom 'occurs in' some forebrain, but the definition suggests this. The ontology therefore has the implicit assumption that all neurons that develop in the forebrain contribute to it. This may be true, but I wouldn't want to assume it. The term has no reference attached and is the only instance of this pattern in the ontology, so I'm not happy with using this as a general pattern.
We define CL & GO terms based on what we know generally from the literature and we may need to make finer distinctions than this particular paper does e.g. do we define hindbrain neuron as 'neuron that has_soma_location some hindbrain', rather than 'neuron that part_of some hindbrain'. |
Discussion from Editor's meeting: Agreement:
|
For 3, we need:
|
What's the next step on this issue, so I can go ahead and add in the 'midbrain dopaminergic neuron differentiation' terms in geneontology/go-ontology#12039? Thank you. |
I need to add new terms that compose 2 uberon terms in a single term name in the development tree of GO.
I need to add midbrain neuron development and hindbrain neuron development.
The template needs to have term 1 part_of term 2 and development part of could be replaced by better relation if desired.
To follow the pattern for forebrain development I came up with the following hierarchy:
[NEW] hindbrain generation of neurons
The process in which nerve cells are generated in the hindbrain. This includes the production of neuroblasts from and their differentiation into neurons.
is_a: GO:0048699 generation of neurons
part_of GO:0030902 hindbrain development
[NEW] hindbrain neuron differentiation
The process in which a relatively unspecialized cell acquires specialized features of a neuron that will reside in the hindbrain.
is_a: GO:0021953 central nervous system neuron differentiation
part_of:[NEW] hindbrain generation of neurons
[NEW]hindbrain neuron development
The process whose specific outcome is the progression of a neuron that resides in the hindbrain, from its initial commitment to its fate, to the fully functional differentiated cell.
is_a: GO:0021954 central nervous system neuron development
part_of: [NEW] hindbrain neuron differentiation
The text was updated successfully, but these errors were encountered: