Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP #12

Merged
merged 6 commits into from
Oct 19, 2016
Merged

WIP #12

merged 6 commits into from
Oct 19, 2016

Conversation

colanconnon
Copy link
Contributor

No description provided.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 63079aa on OP-289-create-object-locator into a99a56d on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-6.7%) to 93.333% when pulling af8d9ab on OP-289-create-object-locator into a99a56d on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-6.7%) to 93.333% when pulling 1f5ce02 on OP-289-create-object-locator into a99a56d on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-6.7%) to 93.333% when pulling d166f5a on OP-289-create-object-locator into a99a56d on master.

@colanconnon colanconnon removed the wip label Oct 19, 2016
@thomasbellio
Copy link
Contributor

thomasbellio commented Oct 19, 2016 •
edited
Loading

@colanconnon Your test coverage dropped here. Looks like you didn't write test cases for error scenarios. https://coveralls.io/builds/8413291/source?filename=src%2FObjectLocator.js

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 5032c0a on OP-289-create-object-locator into a99a56d on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling adda9e0 on OP-289-create-object-locator into a99a56d on master.

@thomasbellio thomasbellio merged commit ddff693 into master Oct 19, 2016
@weklund weklund deleted the OP-289-create-object-locator branch October 20, 2016 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@colanconnon @coveralls @thomasbellio