Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#73271142]helper classes #41

Closed
wants to merge 9 commits into from
Closed

[#73271142]helper classes #41

wants to merge 9 commits into from

Conversation

vwxyz
Copy link
Contributor

@vwxyz vwxyz commented Jul 28, 2014

No description provided.

narusemotoki
narusemotoki reviewed Jul 28, 2014
View reviewed changes
liquid/_includes/components/control-sizing.html
<select class="form-control input-sm">
<option>input-md</option>
<option>input-md</option>
<option>input-md</option>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are same previous my comment. 👀 input-sm, I think.

@narusemotoki
Copy link
Contributor

@vwxyz Why did you send #42 after this Pull Request? #42 seems parent commit of this. Is it mistake? or Did I misunderstand? 😱

@vwxyz
Copy link
Contributor Author

vwxyz commented Jul 28, 2014

@narusemotoki

yes. #42 is parent of this( #41).

Though I intentionally did it, I might do it wrongly. 😓
I should PR #42 earlier than #41, I forgot that, and after noticed it I PR-ed #41

@vwxyz vwxyz closed this Jul 28, 2014
@vwxyz vwxyz mentioned this pull request Jul 28, 2014
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vwxyz @narusemotoki