Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add resdk.tables.MATables for microarray data support #271

Merged

Conversation

JureZmrzlikar
Copy link
Member

No description provided.

@JureZmrzlikar JureZmrzlikar force-pushed the feature/tables-microarray branch 2 times, most recently from 0fcde0e to 5197600 Compare November 23, 2021 07:36
@JureZmrzlikar JureZmrzlikar changed the title WIP: Add resdk.tables.MATables for microarray data support Add resdk.tables.MATables for microarray data support Nov 24, 2021
src/resdk/tables/microarray.py Outdated Show resolved Hide resolved
src/resdk/tables/microarray.py Show resolved Hide resolved
@JureZmrzlikar
Copy link
Member Author

@robertcv I've addressed your comments, please re-review.

Copy link
Contributor

@robertcv robertcv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look OK. I just noticed one more thing. I would like it for exp to include the attrs attribute similar to RNATables. I would add parameters exp_type and platform from the data object output attributes.

@JureZmrzlikar JureZmrzlikar merged commit 773f53b into genialis:master Nov 30, 2021
@JureZmrzlikar JureZmrzlikar deleted the feature/tables-microarray branch November 30, 2021 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants