Improve download #346
Merged
Improve download #346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There are issues with some of the downloads (e.g. HTML fields, e.g. output in multiQC process). The locally computed md5 checksum and the one received from the server are different. Will try to investigate and resolve that with @gregorjerse . |
JureZmrzlikar
force-pushed
the
fortify-file-download
branch
from
a7701f6
to
f18e6c2
Compare
gregorjerse
approved these changes
Feb 5, 2024
| # checksums that are difficult to reproduce here. | ||
| return | ||
| expected_md5 = checksums[file_directory][file_name] | ||
| computed_md5 = md5(os.path.join(download_dir, file_path, file_name)) |
There was a problem hiding this comment.
It would be more efficient to integrate md5 checksum computation in the download process and compute it for each downloaded chunk.
However, computing it after the file is written to disk also captures disk write errors (or, in case of BCM, NFS errors).
JureZmrzlikar
force-pushed
the
fortify-file-download
branch
from
f18e6c2
to
11fa8d9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.