Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce a way that makes the callback feature flexible. #141

Closed
kazunarikudo opened this issue Mar 31, 2020 · 2 comments
Closed

Introduce a way that makes the callback feature flexible. #141

kazunarikudo opened this issue Mar 31, 2020 · 2 comments
Labels
compatibility An issue that affects compatibility improvement New feature or improvement
Milestone
1.2.0

Comments

@kazunarikudo
Copy link
Member

kazunarikudo commented Mar 31, 2020 •
edited

Is your feature request related to a problem? Please describe.
So far, the callback on new buffer arrival is done by a function but it's not flexible at all.

Describe the solution you'd like
Define a base class that is used as the callback.

Describe alternatives you've considered
None.

Additional context
See also issue #61.
@kazunarikudo kazunarikudo added compatibility An issue that affects compatibility improvement New feature or improvement labels Mar 31, 2020
@kazunarikudo kazunarikudo added this to the 1.2.0 milestone Mar 31, 2020
kazunarikudo added a commit that referenced this issue Mar 31, 2020
@kazunarikudo
Resolve issue #141
8ed2812
@kazunarikudo kazunarikudo changed the title Reserved Introduce a way that makes the callback feature flexible. Apr 1, 2020
kazunarikudo added a commit that referenced this issue Apr 1, 2020
@kazunarikudo
Resolve issue #141
4444e56
kazunarikudo added a commit that referenced this issue Apr 1, 2020
@kazunarikudo
Resolve issue #141
a4da38f
kazunarikudo added a commit that referenced this issue Apr 1, 2020
@kazunarikudo
Resolve issue #141
a4807b6
kazunarikudo added a commit that referenced this issue Apr 2, 2020
@kazunarikudo
Resolve issue #141
481c939
kazunarikudo added a commit that referenced this issue Apr 2, 2020
@kazunarikudo
Resolve issue #141
852ab55
kazunarikudo added a commit that referenced this issue Apr 3, 2020
@kazunarikudo
Resolve issue #141
b0bed37
kazunarikudo added a commit that referenced this issue Apr 5, 2020
@kazunarikudo
Resolve issue #141
46539b1
kazunarikudo added a commit that referenced this issue Apr 6, 2020
@kazunarikudo
Resolve issue #141
86f91ed
kazunarikudo added a commit that referenced this issue Apr 6, 2020
@kazunarikudo
Resolve issue #141
988b7e4
kazunarikudo added a commit that referenced this issue Apr 8, 2020
@kazunarikudo
Resolve issue #141
7379193
@TKaluza
Copy link

TKaluza commented May 4, 2020

Not sure how to do it? Because @kazunarikudo is great guy he already added some information in FAQ:Callbacks

@kazunarikudo
Copy link
Member Author

@TKaluza Could you tell me what you would like to know with the callback feature? /Kazunari

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
compatibility An issue that affects compatibility improvement New feature or improvement
Projects
None yet
Milestone
1.2.0
Development

No branches or pull requests
2 participants
@kazunarikudo @TKaluza