Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle InvalidParameterException raided from a GenTL Producer on an inquiry for STREAM_INFO_BUF_ANNOUNCE _MIN #95

Closed
kazunarikudo opened this issue Oct 23, 2019 · 0 comments
Labels
improvement New feature or improvement
Milestone

Comments

@kazunarikudo
Copy link
Member

kazunarikudo commented Oct 23, 2019

Describe the bug
InvalidParameterException is raised from a GenTL Producer on an inquiry for STREAM_INFO_BUF_ANNOUNCE_MIN. In the current implementation, it does not except the case so the program will be terminated.

To Reproduce
Steps to reproduce the behavior:

  1. Load the GenTL Producer which can reproduce the phenomenon.
  2. Create a Harvester object.
  3. Call the create_image_acquirer method on it.
  4. Will see the exception is raised.

Expected behavior
From the Harvester's point of view, it is legal to inquire STREAM_INFO_BUF_ANNOUNCE_MIN and no exception is raised.

Desktop (please complete the following information):

  • OS: [e.g. macOS]
  • Python: [e.g. 3.7]
  • Harvester: [e.g. 0.2.12]
  • GenTL Producer: STEMMER IMAGING
  • Camera: [e.g. Company DEF]

Additional context
None.

Even if it is legal to inquire STREAM_INFO_BUF_ANNOUNCE_MIN it is a fact that CVB raises the exception. In this case, a realistic workaround what we can take is to catch the exception and
apply a reasonable number of buffers instead of having the correct number from the GenTL Producer.

This issue should be kept investigated but we take this workaround anyway.

Remarks
As far as I remember, the issue was not reproduced in the older releases. There might be a change from a recent release.

@kazunarikudo kazunarikudo added the improvement New feature or improvement label Oct 23, 2019
@kazunarikudo kazunarikudo added this to the 0.2.13 milestone Oct 23, 2019
@kazunarikudo kazunarikudo changed the title InvalidParameterException from CVB on an inquiry for STREAM_INFO_BUF_ANNOUNCE _MIN Handle InvalidParameterException raided from a GenTL Producer on an inquiry for STREAM_INFO_BUF_ANNOUNCE _MIN Oct 24, 2019
kazunarikudo added a commit that referenced this issue Oct 24, 2019
kazunarikudo added a commit that referenced this issue Oct 25, 2019
* master: (28 commits)
  Announce the release of 0.2.13
  Clean up
  Clean up
  Add a description for the "show us what you did" campaign
  Resolve issue #95
  Clean up
  Update the interoperability status
  Clean up
  Clean up
  Clean up
  Clean up
  Clean up
  Clean up
  Clean up
  Clean up
  Clean up
  Clean up
  Clean up
  Clean up
  Fix the typo
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement New feature or improvement
Projects
None yet
Development

No branches or pull requests

1 participant