Add HTTP request header authentication to NBI #374
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides an HTTP-header-based NBI authentication solution for the security issue raised in this forum post:
https://forum.genieacs.com/t/secure-rest-api-endpoints-of-genieacs-nbi/1093
The solution adds an optional configuration parameter "NBI_AUTHENTICATION_KEY", which - when present - is required to be present in an "x-api-key" HTTP header of any incoming request. When the "NBI_AUTHENTICATION_KEY" configuration parameter is absent, the current behaviour stands i.e. no authentication is required.