Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HTTP request header authentication to NBI #374

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

markabrahams
Copy link

This PR provides an HTTP-header-based NBI authentication solution for the security issue raised in this forum post:
https://forum.genieacs.com/t/secure-rest-api-endpoints-of-genieacs-nbi/1093

The solution adds an optional configuration parameter "NBI_AUTHENTICATION_KEY", which - when present - is required to be present in an "x-api-key" HTTP header of any incoming request. When the "NBI_AUTHENTICATION_KEY" configuration parameter is absent, the current behaviour stands i.e. no authentication is required.

@markabrahams
Copy link
Author

I'd also like to take the opportunity to thank all contributors to this great project - I was able to stand up GenieACS incredibly quickly and use it to debug some TR-069 client issues I was having. Nice work team!

@josineiaraujo
Copy link

Olá, eu tbm gostaria de ver algum tipo de autenticação na API....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants