Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cpu_state inconsistency #1452

Closed
nfeske opened this issue Mar 16, 2015 · 2 comments
Closed

Cpu_state inconsistency #1452

nfeske opened this issue Mar 16, 2015 · 2 comments
Labels
cleanup fixed

Comments

@nfeske
Copy link
Member

nfeske commented Mar 16, 2015

The Cpu_state class in cpu/cpu_state.h is defined slightly inconsistent across CPU architectures. In base/include/arm/cpu/cpu_state.h, all member variables are uninitialized whereby in base/include/x86_32/cpu/cpu_state.h and base/include/x86_64/cpu/cpu_state.h, all member variables are initialized with 0. Which approach is correct?
@nfeske nfeske added the cleanup label Mar 16, 2015
skalk added a commit to skalk/genode that referenced this issue Mar 6, 2019
@skalk
base: initialize Cpu_state consistently (Fix genodelabs#1452)
abf978d
@skalk
Copy link
Member

skalk commented Mar 6, 2019

The initialization is surely the favored approach. I've changed and tested the ARM cpu_state accordingly in above commit.

@skalk skalk added the fixed label Mar 6, 2019
skalk added a commit to skalk/genode that referenced this issue Mar 7, 2019
@skalk
base: initialize Cpu_state consistently (Fix genodelabs#1452)
0b2f1f5
@skalk
Copy link
Member

skalk commented Mar 7, 2019

@chelmuth I've updated the commit according to your comment.

chelmuth pushed a commit that referenced this issue Mar 7, 2019
@skalk @chelmuth
base: initialize Cpu_state consistently (Fix #1452)
b9c5cf8
chelmuth pushed a commit that referenced this issue Mar 7, 2019
@skalk @chelmuth
base: initialize Cpu_state consistently (Fix #1452)
5293071
chelmuth pushed a commit that referenced this issue Mar 7, 2019
@skalk @chelmuth
base: initialize Cpu_state consistently (Fix #1452)
4e2bd97
trimpim pushed a commit to trimpim/genode that referenced this issue May 21, 2019
@skalk @trimpim
base: initialize Cpu_state consistently (Fix genodelabs#1452)
f612931
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cleanup fixed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nfeske @skalk