Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove os/slave.h and gems/report_rom_slave.h #3754

Closed
nfeske opened this issue May 6, 2020 · 2 comments
Closed

Remove os/slave.h and gems/report_rom_slave.h #3754

nfeske opened this issue May 6, 2020 · 2 comments

Comments

@nfeske
Copy link
Member

nfeske commented May 6, 2020

Those parts of the API were created out of intellectual curiosity but ultimately turned out to be dead ends. Hosting services as children has not become a natural pattern.

In the meantime, all former users of these mechanisms have vanished (#3512). Granted, there is qt_avplay in genode-world, but this application is actually merely reusing the Slave::Policy part of the API and can thereby easily be adapted to the use of the plain Child::Policy.

@nfeske nfeske added the cleanup label May 6, 2020
@nfeske
Copy link
Member Author

nfeske commented Feb 26, 2021

This issue needs the adaptation of the following components:

  • world/src/app/qt_avplay
  • os/src/test/resource_yield
  • os/src/test/dynamic_config

nfeske added a commit that referenced this issue Apr 20, 2021
nfeske added a commit that referenced this issue Apr 20, 2021
nfeske added a commit that referenced this issue Apr 20, 2021
@nfeske
Copy link
Member Author

nfeske commented Apr 20, 2021

The commits referenced above contain the remaining steps to solve this issue for the Genode repository.

Regarding qt_avplay in world, I have merely added a local copy of the original os/slave.h to the application for now. Down the road, we should better adjust the program similar to what I did in fad0ef5.

@nfeske nfeske added the fixed label Apr 20, 2021
nfeske added a commit that referenced this issue May 5, 2021
nfeske added a commit that referenced this issue May 5, 2021
@nfeske nfeske closed this as completed in 6caa74a May 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant