Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pc: update wlan driver #4455

Closed
cnuke opened this issue Mar 25, 2022 · 19 comments
Closed

pc: update wlan driver #4455

cnuke opened this issue Mar 25, 2022 · 19 comments

Comments

@cnuke
Copy link
Member

cnuke commented Mar 25, 2022

The following commits series introduces a new WLAN driver for the PC platform based on the Linux 5.14.2 sources that features support for Intel wireless AX (WIFI-6) devices. It is still WIP as it lacks rfkill support and the management front end integration is not yet properly done. The included wlan-test.run may be executed to test the new driver (so far it was only tested it with a 7265D and AX201 device).
cnuke added a commit to cnuke/genode that referenced this issue Mar 25, 2022
@cnuke
lx_kit: remove execution of static ctors
38a4c57 
In case where the ported driver or protocol stack is executed from
an already managed environment, e.g. the libc, the execution
of the static constructors will be performed at the appropriate
time.

Issue genodelabs#4455.
cnuke added a commit to cnuke/genode that referenced this issue Mar 25, 2022
@cnuke
lx_kit: handle %hu specifier in console
08a8df8 
Prevent '<warning unsupported format specifier>' when encountering
'%hu'.

Issue genodelabs#4455.
cnuke added a commit to cnuke/genode that referenced this issue Mar 25, 2022
@cnuke
lx_emul: get pid from task
8a276eb 
Issue genodelabs#4455.
cnuke added a commit to cnuke/genode that referenced this issue Mar 25, 2022
@cnuke
lx_emul: add additional atomic64 functions
bbd4f7f 
Needed by the WLAN driver on x86_32.

Issue genodelabs#4455.
cnuke added a commit to cnuke/genode that referenced this issue Mar 25, 2022
@cnuke
lx_emul: initialize task members needed by network
47984a2 
Those members are access via static inline functions in the network
core code and from certain protocols, e.g. AF_NETLINK.

Issue genodelabs#4455.
cnuke added a commit to cnuke/genode that referenced this issue Mar 25, 2022
@cnuke
pc_lx_emul: add __put_user
ca015ac 
Issue genodelabs#4455.
cnuke added a commit to cnuke/genode that referenced this issue Mar 25, 2022
@cnuke
pc_lx_emul: use page alloc shadow implementation
1f7349c 
Issue genodelabs#4455.
cnuke added a commit to cnuke/genode that referenced this issue Mar 25, 2022
@cnuke
pc_lx_emul: allow for being used in a library
ade2785 
The location of the used 'source.list' file is hard-coded and will not
work when the ported driver is implemented as a shared library. For
this use-case provide means to set the location differently.

Issue genodelabs#4455.
cnuke added a commit to cnuke/genode that referenced this issue Mar 25, 2022
@cnuke
wifi/socket_call: add MSG_DONTWAIT
d423e7e 
Issue genodelabs#4455.
cnuke added a commit to cnuke/genode that referenced this issue Mar 25, 2022
@cnuke
libnl: use MSG_DONTWAIT
1d96ded 
Issue genodelabs#4455.
cnuke added a commit to cnuke/genode that referenced this issue Mar 25, 2022
@cnuke
wpa_supplicant: remove hard lx_printf dependency
305a710 
Not needed and breaks 'pc_wlan_drv'.

Issue genodelabs#4455.
cnuke added a commit to cnuke/genode that referenced this issue Mar 25, 2022
@cnuke
wifi: add interface query functions
5994dd1 
Various libraries, like libnl and wpa_driver_nl80211, used hardcoded
values for the interface index (ifindex) and name (ifname).
To accomdate the legacy as well as the upcoming new driver we add
functions to query these information where at least the index differs.

Issue genodelabs#4455.
cnuke added a commit to cnuke/genode that referenced this issue Mar 25, 2022
@cnuke
pc: extended pc_linux api archive for WLAN driver
5c446da 
Issue genodelabs#4455.
cnuke added a commit to cnuke/genode that referenced this issue Mar 25, 2022
@cnuke
pc_linux: add wlan stuff to config
e33d03f 
Issue genodelabs#4455.
cnuke added a commit to cnuke/genode that referenced this issue Mar 25, 2022
@cnuke
dde_linux: add linux-firmware port
38bab36 
Move 'linux-firmware' portion from 'dde_linux' into its own port,
while it is used by the upcoming new WLAN driver keep it in place
for the legacy one.

Issue genodelabs#4455.
cnuke added a commit to cnuke/genode that referenced this issue Mar 25, 2022
@cnuke
pc: update wlan driver
2eb1f35 
The driver falls in line with the previous 'wifi_drv' component where
the ported wireless LAN stack and device driver is encapsulated in a
library. This library in return is used by the 'Libc::Component'
providing the necessary environment for the 'wpa_supplicant'.

In constrast to the old driver a 'wlan' VFS plugin is in charge of
initalizing the 'Lx_kit::Env' prior to executing any static
constructors.

Fixes genodelabs#4455.
cnuke added a commit to cnuke/genode that referenced this issue Mar 25, 2022
@cnuke
pc: add wlan test run script
7820d45 
Issue genodelabs#4455.
@cnuke
Copy link
Member Author

cnuke commented Mar 25, 2022

Sculpt integration will follow next week (the pc_wlan_drv recipe is already available). Since I have not yet tested if rejoining or roaming works, I'll expect one or the other rough edge.

cnuke added a commit to cnuke/genode that referenced this issue Mar 28, 2022
@cnuke
lx_kit: remove execution of static ctors
e2d3199 
In case where the ported driver or protocol stack is executed from
an already managed environment, e.g. the libc, the execution
of the static constructors will be performed at the appropriate
time.

Issue genodelabs#4455.
cnuke added a commit to cnuke/genode that referenced this issue Mar 28, 2022
@cnuke
lx_kit: handle %hu specifier in console
41895ea 
Prevent '<warning unsupported format specifier>' when encountering
'%hu'.

Issue genodelabs#4455.
cnuke added a commit to cnuke/genode that referenced this issue Mar 28, 2022
@cnuke
lx_emul: get pid from task
a6b873f 
Issue genodelabs#4455.
cnuke added a commit to cnuke/genode that referenced this issue Mar 28, 2022
@cnuke
lx_emul: add additional atomic64 functions
ff7771a 
Needed by the WLAN driver on x86_32.

Issue genodelabs#4455.
cnuke added a commit to cnuke/genode that referenced this issue Mar 28, 2022
@cnuke
lx_emul: initialize task members needed by network
7830b69 
Those members are access via static inline functions in the network
core code and from certain protocols, e.g. AF_NETLINK.

Issue genodelabs#4455.
cnuke added a commit to cnuke/genode that referenced this issue Mar 28, 2022
@cnuke
pc_lx_emul: add __put_user
29c2ddc 
Issue genodelabs#4455.
cnuke added a commit to cnuke/genode that referenced this issue Mar 28, 2022
@cnuke
pc_lx_emul: use page alloc shadow implementation
397d3ee 
Issue genodelabs#4455.
cnuke added a commit to cnuke/genode that referenced this issue Mar 28, 2022
@cnuke
pc_lx_emul: allow for being used in a library
f5e665b 
The location of the used 'source.list' file is hard-coded and will not
work when the ported driver is implemented as a shared library. For
this use-case provide means to set the location differently.

Issue genodelabs#4455.
cnuke added a commit to cnuke/genode that referenced this issue Mar 28, 2022
@cnuke
wifi/socket_call: add MSG_DONTWAIT
19f8bc4 
Issue genodelabs#4455.
cnuke added a commit to cnuke/genode that referenced this issue Mar 28, 2022
@cnuke
libnl: use MSG_DONTWAIT
0e545d7 
Issue genodelabs#4455.
cnuke added a commit to cnuke/genode that referenced this issue Mar 28, 2022
@cnuke
wpa_supplicant: remove hard lx_printf dependency
140d970 
Not needed and breaks 'pc_wlan_drv'.

Issue genodelabs#4455.
cnuke added a commit to cnuke/genode that referenced this issue Mar 28, 2022
@cnuke
wifi: add interface query functions
42a58b6 
Various libraries, like libnl and wpa_driver_nl80211, used hardcoded
values for the interface index (ifindex) and name (ifname).
To accomdate the legacy as well as the upcoming new driver we add
functions to query these information where at least the index differs.

Issue genodelabs#4455.
chelmuth pushed a commit that referenced this issue Apr 13, 2022
@cnuke @chelmuth
lx_kit: remove execution of static ctors
ffea0bf 
In case where the ported driver or protocol stack is executed from
an already managed environment, e.g. the libc, the execution
of the static constructors will be performed at the appropriate
time.

Issue #4455.
chelmuth pushed a commit that referenced this issue Apr 13, 2022
@cnuke @chelmuth
lx_kit: handle %hu specifier in console
4b43b5c 
Prevent '<warning unsupported format specifier>' when encountering
'%hu'.

Issue #4455.
chelmuth pushed a commit that referenced this issue Apr 13, 2022
@cnuke @chelmuth
lx_emul: get pid from task
0c61736 
Issue #4455.
chelmuth pushed a commit that referenced this issue Apr 13, 2022
@cnuke @chelmuth
lx_emul: add additional atomic64 functions
77cdcea 
Needed by the WLAN driver on x86_32.

Issue #4455.
chelmuth pushed a commit that referenced this issue Apr 13, 2022
@cnuke @chelmuth
lx_emul: initialize task members needed by network
edb0877 
Those members are access via static inline functions in the network
core code and from certain protocols, e.g. AF_NETLINK.

Issue #4455.
chelmuth pushed a commit that referenced this issue Apr 13, 2022
@cnuke @chelmuth
pc_lx_emul: add __put_user
b2e11f1 
Issue #4455.
chelmuth pushed a commit that referenced this issue Apr 13, 2022
@cnuke @chelmuth
pc_lx_emul: use page alloc shadow implementation
7cd8285 
Issue #4455.
chelmuth pushed a commit that referenced this issue Apr 13, 2022
@cnuke @chelmuth
pc_lx_emul: allow for being used in a library
24c0bb9 
The location of the used 'source.list' file is hard-coded and will not
work when the ported driver is implemented as a shared library. For
this use-case provide means to set the location differently.

Issue #4455.
chelmuth pushed a commit that referenced this issue Apr 13, 2022
@cnuke @chelmuth
wifi/socket_call: add MSG_DONTWAIT
f5eddce 
Issue #4455.
chelmuth pushed a commit that referenced this issue Apr 13, 2022
@cnuke @chelmuth
libnl: use MSG_DONTWAIT
447f3fc 
Issue #4455.
chelmuth pushed a commit that referenced this issue Apr 13, 2022
@cnuke @chelmuth
wpa_supplicant: remove hard lx_printf dependency
c1fea8c 
Not needed and breaks 'pc_wlan_drv'.

Issue #4455.
chelmuth pushed a commit that referenced this issue Apr 13, 2022
@cnuke @chelmuth
wifi: add interface query functions
56427da 
Various libraries, like libnl and wpa_driver_nl80211, used hardcoded
values for the interface index (ifindex) and name (ifname).
To accomdate the legacy as well as the upcoming new driver we add
functions to query these information where at least the index differs.

Issue #4455.
chelmuth pushed a commit that referenced this issue Apr 13, 2022
@cnuke @chelmuth
pc: extended pc_linux api archive for wifi driver
0a6baff 
Issue #4455.
chelmuth pushed a commit that referenced this issue Apr 13, 2022
@cnuke @chelmuth
pc_linux: add wlan stuff to config
c9d9ec0 
Issue #4455.
chelmuth pushed a commit that referenced this issue Apr 13, 2022
@cnuke @chelmuth
pc: update framebuffer/intel for new Linux config
838bae9 
This is needed because now 'kobject_uevent.c' pulls netlink related
code in.

Issue #4455.
chelmuth pushed a commit that referenced this issue Apr 13, 2022
@cnuke @chelmuth
dde_linux: add linux-firmware port
0bd1a53 
Move 'linux-firmware' portion from 'dde_linux' into its own port,
while it is used by the upcoming new WLAN driver keep it in place
for the legacy one.

Issue #4455.
chelmuth pushed a commit that referenced this issue Apr 13, 2022
@cnuke @chelmuth
Rename wifi_drv to legacy_wifi_drv
8056811 
Issue #4455.
chelmuth pushed a commit that referenced this issue Apr 13, 2022
@cnuke @chelmuth
sculpt: use pc_wifi_drv
dd09e90 
Issue #4455.
chelmuth pushed a commit that referenced this issue Apr 13, 2022
@cnuke @chelmuth
ports: use new wifi driver in netperf
b6471a8 
Issue #4455.
chelmuth added a commit that referenced this issue Apr 13, 2022
@chelmuth
Remove pkg runtime for pc_wifi_drv/legacy_pc_wifi_drv
520a08b 
Both runtimes were broken due to missing requirement for "Uplink"
service and thus unused.

Issue #4455
chelmuth pushed a commit that referenced this issue Apr 13, 2022
@cnuke @chelmuth
dde_linux: use new wifi driver in uplinks test
2e47eb6 
Issue #4455.
@cnuke
Copy link
Member Author

cnuke commented Apr 19, 2022 •
edited

@chelmuth please see answers below:

Do we have any chance to trigger such reauth requests regularly in our testing environment?

Yes, we could use the ubus interface via ssh on an OpenWrt AP to force de-/reauthentication.

How does Linux WPA Supplicant play with these?

I did not check how it fares but I guess it will cope with the situation. AFAICT the problems mainly arise from how we interact with the supplicant. My commit accab77 addresses this by ignoring it on our side, which leads to the supplicant doing its thing and rejoining the network.

I vaguely remember As documented in #4083 @nfeske having some issue in the past where he could not rejoin a network after he got disconnected. This is probably due to disabling the network (I changed that to removing the network in my debug commit 9069335) in case we get disconnected. Since it never gets re-enabled from our side the supplicant will not join the network again.

All in all we should spend some time to rework the wifi management state-machine.

cnuke added a commit to cnuke/genode that referenced this issue Apr 21, 2022
@cnuke
WIP pc_wifi_drv: handle reauth silently
84067b3 
(Hopefully it plays well with wpa_supplicant's AP auto-select…)

Issue genodelabs#4455.
cnuke added a commit to cnuke/genode that referenced this issue Apr 22, 2022
@cnuke
WIP pc_wifi_drv: handle reauth silently
f5e86e2 
(Hopefully it plays well with wpa_supplicant's AP auto-select…)

Issue genodelabs#4455.
chelmuth pushed a commit that referenced this issue Apr 25, 2022
@cnuke @chelmuth
pc_wifi_drv: do not reset call result
7d42883 
Issue #4983
Issue #4455
@cnuke cnuke mentioned this issue Apr 27, 2022
Closed
chelmuth pushed a commit that referenced this issue Apr 28, 2022
@cnuke @chelmuth
pc_wifi_drv: do not reset call result
754d352 
Issue #4983
Issue #4455
nfeske added a commit to genodelabs/genode-allwinner that referenced this issue May 6, 2022
@nfeske
Adapt to lx_kit constructor change
3b6ba38 
Static constructors are no longer implicitly called by
Lx_kit::initialize() but must be called explicitly afterwards.

Issue genodelabs/genode#4455
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jschlatow @chelmuth @cnuke