Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

part_block: use expanding reporter #4782

Closed
cnuke opened this issue Mar 10, 2023 · 1 comment
Closed

part_block: use expanding reporter #4782

cnuke opened this issue Mar 10, 2023 · 1 comment
Labels

Comments

@cnuke
Copy link
Member

cnuke commented Mar 10, 2023

As reported on the mailling-list using Sculpt with a disk that contains many partitions does not work. Although part_block is able to parse the partition-table (as shown in the LOG) it later complains that no valid partition table was found.
This behaviour is due to the fact the component cannot generate the partitions report as the underlying buffer is too small, which results in an exeception that is silently caught and treated as a non-valid partition-table.

The following commit addresses this short-coming by replacing the static Reporter with an Expanding_reporter.

cnuke added a commit to cnuke/genode that referenced this issue Mar 10, 2023
Depending on the number of partitions the current fixed size of 4096
bytes might not be sufficient for the resulting partitions report.
The use of the expanding reporter allows for accomodating large reports
while still keeping the resource usage down for the common case of
few partitions (with potentially short names).

Fixes genodelabs#4782.
@cnuke
Copy link
Member Author

cnuke commented Mar 10, 2023

Commit e7d7b46 fixes this issue.

@cnuke cnuke added the fixed label Mar 10, 2023
chelmuth pushed a commit that referenced this issue Mar 10, 2023
Depending on the number of partitions the current fixed size of 4096
bytes might not be sufficient for the resulting partitions report.
The use of the expanding reporter allows for accomodating large reports
while still keeping the resource usage down for the common case of
few partitions (with potentially short names).

Fixes #4782.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant