fix(core): canvas sizing when it doesn't fill the whole container

Overhang was erroneously added twice.
genome-spy · Mar 12, 2024 · 393cab5 · 393cab5
1 parent 3aeb8dd
commit 393cab5
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 10 deletions.
diff --git a/packages/core/src/genomeSpy.js b/packages/core/src/genomeSpy.js
@@ -10,7 +10,6 @@ import {
     checkForDuplicateScaleNames,
     setImplicitScaleNames,
     calculateCanvasSize,
-    calculateViewRootSize,
 } from "./view/viewUtils.js";
 import UnitView from "./view/unitView.js";
 
@@ -365,7 +364,7 @@ export default class GenomeSpy {
             canvasWrapper,
             () =>
                 this.viewRoot
-                    ? calculateCanvasSize(calculateViewRootSize(this.viewRoot))
+                    ? calculateCanvasSize(this.viewRoot.getSize())
                     : { width: undefined, height: undefined },
             this.spec.background,
             { powerPreference: this.options.powerPreference ?? "default" }
@@ -542,7 +541,7 @@ export default class GenomeSpy {
         );
 
         this.#canvasWrapper.style.flexGrow =
-            calculateViewRootSize(this.viewRoot).height.grow > 0 ? "1" : "0";
+            this.viewRoot.getSize().height.grow > 0 ? "1" : "0";
 
         this.#initializeParameterBindings();
 

diff --git a/packages/core/src/view/viewUtils.js b/packages/core/src/view/viewUtils.js
@@ -244,13 +244,6 @@ export function findUniqueViewNames(root) {
  */
 export const isCustomViewName = (name) => !/^(layer|concat)\d+$/.test(name);
 
-/**
- * @param {View} viewRoot
- */
-export function calculateViewRootSize(viewRoot) {
-    return viewRoot.getSize().addPadding(viewRoot.getOverhang());
-}
-
 /**
  * @param {import("./layout/flexLayout.js").FlexDimensions} viewRootSize
  */