fix(core): "link" mark's other endpoint didn't quite reach the target

Fell one vertex pair short.
genome-spy · Mar 8, 2024 · fc10bff · fc10bff
1 parent fb46978
commit fc10bff
Showing 1 changed file with 11 additions and 7 deletions.
diff --git a/packages/core/src/marks/link.js b/packages/core/src/marks/link.js
@@ -139,7 +139,7 @@ export default class LinkMark extends Mark {
         this.registerMarkUniformValue(
             "uSegmentBreaks",
             props.segments,
-            (x) => x + 1
+            (x) => x
         );
         this.registerMarkUniformValue(
             "uNoFadingOnPointSelection",
@@ -207,6 +207,14 @@ export default class LinkMark extends Mark {
     render(options) {
         const gl = this.gl;
 
+        const getInstanceVertexCount = () => {
+            const breaks = /** @type {Float32Array} */ (
+                this.markUniformInfo.uniforms.uSegmentBreaks
+            )[0];
+
+            return (breaks + 1) * 2;
+        };
+
         return this._baseInstanceExt
             ? this.createRenderCallback((offset, count) => {
                   // Using the following extension, which, however, is only a draft and
@@ -216,9 +224,7 @@ export default class LinkMark extends Mark {
                   this._baseInstanceExt.drawArraysInstancedBaseInstanceWEBGL(
                       gl.TRIANGLE_STRIP,
                       0,
-                      /** @type {Float32Array} */ (
-                          this.markUniformInfo.uniforms.uSegmentBreaks
-                      )[0] * 2,
+                      getInstanceVertexCount(),
                       count,
                       offset
                   );
@@ -254,9 +260,7 @@ export default class LinkMark extends Mark {
                   gl.drawArraysInstanced(
                       gl.TRIANGLE_STRIP,
                       0,
-                      /** @type {Float32Array} */ (
-                          this.markUniformInfo.uniforms.uSegmentBreaks
-                      )[0] * 2,
+                      getInstanceVertexCount(),
                       count
                   );
               }, options);