Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

23andMe deletions #11

Closed
mathiasbynens opened this issue Apr 19, 2015 · 5 comments
Closed

23andMe deletions #11

mathiasbynens opened this issue Apr 19, 2015 · 5 comments

Comments

@mathiasbynens
Copy link
Contributor

23andMe indicates deletions with D. Other groups use other standards.

genomejs/gql#4 (comment)
genomejs/gql#4 (comment)

@yocontra
Copy link
Member

Found a bunch more info on the 23andme API docs

https://api.23andme.com/docs/reference/#genotypes

"For the user's profile, returns the base-pairs, like AA, for the given locations. The value can have Ds or Is for deletions and insertions (for example, DD or DI). It can be __ if the customer is not on a chip that calls that location, or hasn't yet unlocked their call since it corresponds to a sensitive report. It can be -- if the customer is on a chip that calls that location, but we could not determine it. To keep consistency with the /genomes endoint, which always returns two base pairs, hemizygous calls (such as on X-linked genes in males) will also return two base pairs."

Cases to cover correctly: --, DD, DI, __

For __ we should probably log an error that says the user needs to go click "unlock" or whatever on 23andme to get the data

@mathiasbynens
Copy link
Contributor Author

Note that some users cannot unlock this data at all:

Your 23andMe kit was purchased on November 22, 2013 or later, granting you access to only ancestry information and uninterpreted raw data

@yocontra
Copy link
Member

fixed in 1.1.2

@zhaofengli
Copy link
Contributor

No call (-- in raw data) isn't the same as deletion. SNP-JSON perhaps should use ?? to indicate no-calls.

@yocontra
Copy link
Member

yocontra commented Jul 6, 2017

@zhaofengli That makes sense, want to send a PR? I think https://github.com/genomejs/gql might need some tweaks for that.

Have you seen any docs on the 23andme csv format?

This was referenced Jul 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants