Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate GtFeatureStream, replace with GtFeatureInStream #68

Merged
merged 3 commits into from
Aug 27, 2013

Conversation

standage
Copy link
Contributor

Addresses comments raised in #56. Simply doing a typedef of gt_feature_in_stream_new to gt_feature_stream_new gave the desired functionality, but did not generate the desired (HTML) documentation. Thus the trivial constructor implementation.

As far as region node ranges, the default functionality is probably sufficient. I'll worry about providing the option for gt_feature_index_get_orig_range_for_seqid if the need ever arises.

Simply doing a typedef of gt_feature_in_stream_new to gt_feature_stream_new was gave the desired functionality, but did not generate the desired (HTML) documentation. Thus the trivial constructor implementation.
@Garonenur
Copy link
Member

maybe there should be something in the docu-system for functions marked as deprecated and functionality to recognize typedefed functions as new functions.
I think the compilers will remove this layer of indirection but typedefing seems more direct to me.

Garonenur added a commit that referenced this pull request Aug 27, 2013
Deprecate GtFeatureStream, replace with GtFeatureInStream
@Garonenur Garonenur merged commit 31bedad into genometools:master Aug 27, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants