Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: interactive visualisation of cnvkit results #186

Merged
merged 37 commits into from Sep 16, 2022

Conversation

maehler
Copy link
Contributor

@maehler maehler commented Sep 8, 2022

This PR:

Added: standalone interactive HTML report of cnvkit results

Review and tests:

  • Tests pass
  • If you've fixed a bug or added code that should be tested, add tests!
  • Code review
  • CHANGELOG.md is updated
  • New code is executed and covered by tests, and test approve

Still not great, but I leave this for now since it's mostly cosmetic.
It's still a bit buggy, especially with rapid mouse movement. Good
enough for now though.
More could be added, but this also adds some complexity. Maybe later.
Resulting in smoother and more sensible transitions.
@maehler maehler changed the title Cnvkit interactive visualisation feat: interactive visualisation of cnvkit results Sep 8, 2022
@maehler maehler marked this pull request as ready for review September 9, 2022 14:20
workflow/rules/cnvkit_report.smk Outdated Show resolved Hide resolved
workflow/rules/cnvkit_report.smk Show resolved Hide resolved
@maehler maehler merged commit adef115 into develop Sep 16, 2022
@maehler maehler deleted the cnvkit-interactive-visualisation branch September 16, 2022 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants