feat(fetch): add option NO_DEFAULT_PATH for find_package when generating file pkg.dep.cmake
#14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ating file pkg.dep.cmake If `NO_DEFAULT_PATH` option is not added, cmake may search paths out of the project directories, which may find a wrong lib version for linking. By adding this option to `find_package`, we can tell cmake to search lib in project's `vendor` directory to avoid the above issue.
Instead of directly adding `NO_DEFAULT_PATH` to the cmake generating template, we now add a new cli flag `find-package-arg` with a default value (the default value is `NO_DEFAULT_PATH`). This strategy can be more flexible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
NO_DEFAULT_PATHoption is not added, cmake may search paths out of the project directories, which may find a wrong lib version for linking. By adding this option tofind_package, we can tell cmake to search lib in project'svendordirectory to avoid the above issue.