Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Weapon base ATK cast to strings #40

Closed
apex2504 opened this issue Mar 27, 2021 · 2 comments
Closed

Weapon base ATK cast to strings #40

apex2504 opened this issue Mar 27, 2021 · 2 comments

Comments

@apex2504
Copy link
Contributor

I noticed that the "baseAttack" for weapons are cast to strings rather than integers/numbers/whatever. Is this intentional, or would ints/numbers be a more appropriate type for these?
@NurMarvin
Copy link
Member

Probably unintended, since that data was gathered through scraping and number strings weren't transformed to numbers. Will fix this in a bit.

@NurMarvin
Copy link
Member

Closed via 8cb7754

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@NurMarvin @apex2504