Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 4.6 #272

Merged
merged 12 commits into from
May 14, 2024
Merged

Update 4.6 #272

merged 12 commits into from
May 14, 2024

Conversation

majkus522
Copy link
Contributor

No description provided.

@man90es man90es mentioned this pull request May 11, 2024
@M4GICB M4GICB mentioned this pull request May 11, 2024
assets/data/boss/weekly-boss/the-knave/en.json Outdated Show resolved Hide resolved
assets/data/weapons/crimson-moon-s-semblance/en.json Outdated Show resolved Hide resolved
{
"name": "All Is Ash",
"unlock": "Elemental Skill",
"description": "Summons forth Balemoon Bloodfire, dealing Pyro DMG to multiple nearby opponents and performing a dash-cleave against one of them, dealing AoE Pyro DMG.\nOpponents hit by the aforementioned attack will have a Blood-Debt Directive applied to them.\nBlood-Debt Directive\nLasts 30s. Every 5s, it will deal 1 instance of Pyro DMG to the opponent. Max 2 instances. This DMG will be considered Elemental Skill DMG.\nWhen Arlecchino uses a Charged Attack or her Elemental Burst, Balemoon Rising, she will absorb and clear nearby Blood-Debt Directives. Each Directive absorbed grants her a Bond of Life worth 65% of her Max HP.\nThe maximum value of the Bond of Life she can be granted through Blood-Debt Directives within 35s after using her Elemental Skill is 145% of her Max HP. Using the Elemental Skill again during this duration will restart the count on duration and the limit on the value of Bond of Life she may gain from Blood-Debt Directives.",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's also this text in italic at the bottom. Do we add it?
image

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't look like its included for other characters (Diluc for example) so I would say no.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm pretty sure I included it in my PRs for 2023 characters

{
"name": "Balemoon Rising",
"unlock": "Elemental Burst",
"description": "Arlecchino's great wing of Balemoon Bloodfire beats as she absorbs and clears Blood-Debt Directives around her. She deals AoE Pyro DMG before clearing the CD of All Is Ash and healing herself. The healing is based on her Bond of Life value and ATK.",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above --- text in italic

image

@man90es man90es requested a review from M4GICB May 14, 2024 17:52
@M4GICB M4GICB merged commit 6d7f29b into genshindev:mistress May 14, 2024
@majkus522 majkus522 deleted the update_4.6 branch May 14, 2024 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants