Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix kazuha consuming 2 xianyun q stacks in 1 plunge from skill #2046

Merged
merged 1 commit into from
Mar 11, 2024
Merged

fix kazuha consuming 2 xianyun q stacks in 1 plunge from skill #2046

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions internal/characters/xianyun/burst.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,11 @@ const (
burstRadius = 7
burstDoTRadius = 4.8
burstDoTDelay = 5
// TODO: fragile
// used to make sure that only 1 plunge dmg instance consumes an adeptal assistance stack
// purely needed because of kazuha a1 right now
lossKey = "xianyun-burst-loss-icd"
lossIcd = 3
)

// TODO: dummy frame data from shenhe
Expand Down Expand Up @@ -122,6 +127,11 @@ func (c *char) burstPlungeDoTTrigger() {
return false
}

if c.StatusIsActive(lossKey) {
return false
}
c.AddStatus(lossKey, lossIcd, false)

aoe := combat.NewCircleHitOnTarget(c.Core.Combat.Player(), nil, burstDoTRadius)
ai := combat.AttackInfo{
ActorIndex: c.Index,
Expand Down
Loading