Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Substatopt allsubtypes #2094

Merged
merged 9 commits into from Apr 4, 2024
Merged

Conversation

Charlie-Zheng
Copy link
Contributor

Made updates to allow all substats to be considered for each character. This fixes edge cases like Geo characters using Bennett C6 to vaporize, or Xianyun wanting Flat ATK in some configs, or healing characters needing to build HP for Clammage or Furina Fanfare. Additionally this means that new characters no longer need to update the substat optimizer when they scale beyond the traditional ATK/CR/CD/EM stats.

I ran the current live substat optimizer and the new proposed substat optimizer on my Windows 10 system with AMD Ryzen 7 5800HS with 40 GB of 3200 MHz DDR4 and recorded the results and timings. Time for the Control is the time the sim takes to run 1000 iterations. The Time for the substat optimizer is the time it takes to run the optimizer (-substatOptim).

The LyneyFixed config takes the above recommendation and modifies the .lyney.burst.ready condition to .lyney.burst.ready && .lyney.energy == .lyney.energymax

Sim Control New (All Sub Types) Live
Link DPS Time (s) DPS Time (s) DPS Time (s)
95k hyperbloom https://gcsim.app/db/GQHGLq9kGzRB 95037 1.811 95173 8.861 95172 8.871
APLBurstEveryRot https://gcsim.app/db/t6fqtRGTdWnj 71999 5.857 71103 32.654 71294 33.108
LyneyFixed https://gcsim.app/db/t9Ff8tm9fgdd 86646 1.168 86300 3.516 86309 3.819
RandomDelays https://gcsim.app/db/rmLgkH77cgrj 79524 3.335 79646 9.506 79599 9.708

@Charlie-Zheng Charlie-Zheng marked this pull request as draft March 20, 2024 04:10
@Charlie-Zheng Charlie-Zheng marked this pull request as ready for review March 20, 2024 04:43
@srliao srliao merged commit 2822367 into genshinsim:main Apr 4, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants