Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made updates to allow all substats to be considered for each character. This fixes edge cases like Geo characters using Bennett C6 to vaporize, or Xianyun wanting Flat ATK in some configs, or healing characters needing to build HP for Clammage or Furina Fanfare. Additionally this means that new characters no longer need to update the substat optimizer when they scale beyond the traditional ATK/CR/CD/EM stats.
I ran the current live substat optimizer and the new proposed substat optimizer on my Windows 10 system with AMD Ryzen 7 5800HS with 40 GB of 3200 MHz DDR4 and recorded the results and timings. Time for the Control is the time the sim takes to run 1000 iterations. The Time for the substat optimizer is the time it takes to run the optimizer (
-substatOptim
).The
LyneyFixed
config takes the above recommendation and modifies the.lyney.burst.ready
condition to.lyney.burst.ready && .lyney.energy == .lyney.energymax