Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect routes with restrictions on babalmandab #32

Closed
Niloufar375 opened this issue Apr 30, 2024 · 3 comments
Closed

Incorrect routes with restrictions on babalmandab #32

Niloufar375 opened this issue Apr 30, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@Niloufar375
Copy link

Niloufar375 commented Apr 30, 2024

``Hello,
As you know with the current situation of the red sea crisis, most of the vessels are passing through the cape of good hope instead of taking the babalmandab region . My problem is concerning routes for origin/destination ports such as Singapore and Jeddah , where the vessels are passing through the cape of good hope then suez canal to meet the port call Jeddah. However, with the current argument in the route calculation function the restriction for 'babalmandab' does not seem to have any effect as I still get the route that passes through this region ( babalmandab ) .

route = sr.searoute(origin, destination,restrictions=['babalmandab'])

Screenshot 2024-04-30 173349

genthalili added a commit that referenced this issue Jun 5, 2024
@genthalili genthalili added the bug Something isn't working label Jun 5, 2024
@genthalili
Copy link
Owner

Hi @Niloufar375,
This was obviously a bug in the marnet network which had a hidden connected line on top of "babalmandab" passage, now it's fixed and will be visible in version 1.4.0 from pypi.

Meanwhile you can use this commit 4dce9f5

image

Thanks for reporting this!

@Niloufar375
Copy link
Author

Hey @genthalili !

Thanks for making the change , can I ask if you have a rough idea of when you will release the new version ?

@genthalili
Copy link
Owner

it should be ready during coming days, latest next week.

there is a need to test some new functionalities as some important changes have been made, also feel free to test at your end for your specific case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants