New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: limit max height and add autoscroll for dropdown list #163

Merged
merged 1 commit into from Sep 25, 2018

Conversation

Projects
None yet
2 participants
@cschockaert

cschockaert commented Sep 25, 2018

This is a quick and dirty fix to resolve too long dropdown list referenced in this issue:

gentics/mesh#218

@cschockaert cschockaert force-pushed the cschockaert:fix-dropdown-height branch from 5add345 to 4af5d65 Sep 25, 2018

@philippguertler

This comment has been minimized.

Contributor

philippguertler commented Sep 25, 2018

Would it work for you if we instead of your changes just added these two rules to the .contents class?

    max-height: 450px;
    overflow: auto;

This would change the look from this
screenshot_20180925_115733

to this:

screenshot_20180925_115634

@cschockaert cschockaert force-pushed the cschockaert:fix-dropdown-height branch from 4af5d65 to 89f3ed2 Sep 25, 2018

@cschockaert

This comment has been minimized.

cschockaert commented Sep 25, 2018

@philippguertler you are rigth, just tested that solution on local and it worked like a charm
thanks, i updated this PR

@cschockaert cschockaert changed the title from fix: quick & dirty limit top and max height for dropdown list to fix: limit max height and add autoscroll for dropdown list Sep 25, 2018

@philippguertler philippguertler merged commit 98d9640 into gentics:beta Sep 25, 2018

1 check passed

clahub All contributors have signed the Contributor License Agreement.
Details
@philippguertler

This comment has been minimized.

Contributor

philippguertler commented Sep 25, 2018

Great! Glad it worked for you. The fix will be included in the next release of Mesh.

@cschockaert cschockaert deleted the cschockaert:fix-dropdown-height branch Sep 25, 2018

@philippguertler

This comment has been minimized.

Contributor

philippguertler commented Oct 3, 2018

@cschockaert The fix is now released and available in Mesh 0.24.1

@philippguertler

This comment has been minimized.

Contributor

philippguertler commented Oct 3, 2018

Fixes #46

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment