Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: limit max height and add autoscroll for dropdown list #163

Merged
merged 1 commit into from Sep 25, 2018

Conversation

cschockaert
Copy link

This is a quick and dirty fix to resolve too long dropdown list referenced in this issue:

gentics/mesh#218

@philippguertler
Copy link
Contributor

Would it work for you if we instead of your changes just added these two rules to the .contents class?

    max-height: 450px;
    overflow: auto;

This would change the look from this
screenshot_20180925_115733

to this:

screenshot_20180925_115634

@cschockaert
Copy link
Author

@philippguertler you are rigth, just tested that solution on local and it worked like a charm
thanks, i updated this PR

@cschockaert cschockaert changed the title fix: quick & dirty limit top and max height for dropdown list fix: limit max height and add autoscroll for dropdown list Sep 25, 2018
@philippguertler philippguertler merged commit 98d9640 into gentics:beta Sep 25, 2018
@philippguertler
Copy link
Contributor

Great! Glad it worked for you. The fix will be included in the next release of Mesh.

@cschockaert cschockaert deleted the fix-dropdown-height branch September 25, 2018 14:15
@philippguertler
Copy link
Contributor

@cschockaert The fix is now released and available in Mesh 0.24.1

@philippguertler
Copy link
Contributor

Fixes #46

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants