Travis: Remove marker env vars #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because they cause separate caches, which means the cache is useless for our use cases. See travis-ci/travis-ci#5898 for related issue
audiodef
approved these changes
Jul 14, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just ran into this issue that whilst we now have a nice cache on master the PRs are actually not able to make use of it because the env vars set per job in the Travis CI matrix also impact if the cache is shared.
If the env vars differ the cache isn't shared :(
Fixed by getting rid of the marker env vars.
Unfortunately this means no clear overview in travis which job is which. Luckily we only have four and they have pretty distinguishable runtimes, so imho whilst it's less than ideal it's still doable.
See travis-ci/travis-ci#5898 for a related issue about this.
I didn't remove the newversioncheck env var because we don't need to share cache with that job, which means we can at least easily identify that one :)