Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hackport update for newer cabal #6

Closed
wants to merge 1 commit into from
Closed

Hackport update for newer cabal #6

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Jul 2, 2012

  • changed embedded 1.12 to forked one (1.15), opened pull request to upstream, suggest to move fork to gentoo-haskell (TODO)
  • updated Portage/GHC***.hs for newer cabal compatibility
  • fix cabal file & version++ :)
  • moved Path cabal files to root repo directory because of trying to keep forked cabal repository (submodule) as is.

Thoughts (TODO):

@trofi
Copy link
Contributor

trofi commented Jul 2, 2012

The history of hacport.cabal seems to be severely cluttered.

compare two outputs:

git log -p origin/master..nensha/master -- hackport.cabal

git diff -u origin/master..nensha/master -- hackport.cabal

The second one could be even shorter :]

@trofi
Copy link
Contributor

trofi commented Jul 2, 2012

And I'm not sure we really need separate cabal repo for it.
There is no expected development in it safe 2-3 local patches.

@ghost
Copy link
Author

ghost commented Jul 2, 2012

oh... you can merge then in your own commit... I were working on re-commiting updates but here is little mistake :)

@ghost
Copy link
Author

ghost commented Jul 2, 2012

But it's easier to update forked repository and keep the eye on it. Another good way is processing patches by patching but I more like fork way. In my opinion making another git project embedded is not better way since we lost some clarity :)

At least it's still being possible to update cabal in manual way to avoid annoying warning about outdated cabal.

 - changed embedded 1.12 to forked one (1.15), opened pull request to upstream, suggest to move fork to gentoo-haskell (TODO)
 - updated Portage/GHC***.hs for newer cabal compatibility
 - fix cabal file & version++ :)
 - moved Path cabal files to root repo directory because of trying to keep forked cabal repository (submodule) as is.

Thoughts (TODO):

 - move default hackage directory to ~
 - request hackport-9999 package update gentoo-haskell/gentoo-haskell#147 (recursive :D)

Author:    Nensha <NenGraphy@gmail.com>
@trofi
Copy link
Contributor

trofi commented Jul 2, 2012

Forked cabal under gentoo-haskell and applied your patches (i've slightly modified them though).

Thank you!

@trofi trofi closed this Jul 2, 2012
@ghost
Copy link
Author

ghost commented Jul 2, 2012

Good :) Thank you for applieng

you made it better specially in Portage/GHCCore.hs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants