Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some Dancer2 plugins and their dependencies #17

Merged
merged 8 commits into from Sep 13, 2014
Merged

Add some Dancer2 plugins and their dependencies #17

merged 8 commits into from Sep 13, 2014

Conversation

akreal
Copy link
Contributor

@akreal akreal commented Jun 21, 2014

No description provided.

EAPI=5
MODULE_AUTHOR=AMBS
MODULE_VERSION=0.06
MODULE_A="Dancer/${PN}-${MODULE_VERSION}.${MODULE_A_EXT:-tar.gz}"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MODULE_SECTION="Dancer"

Would work here.

Due to this line in the eclass

[[ -z "${SRC_URI}" && -n "${MODULE_AUTHOR}" ]] && \
        SRC_URI="mirror://cpan/authors/id/${MODULE_AUTHOR:0:1}/${MODULE_AUTHOR:0:2}/${MODULE_AUTHOR}/${MODULE_SECTION:+${MODULE_SECTION}/}${MODULE_A}"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noted, thx.

@kentfredric
Copy link
Member

  • Going to pull in what I can ( with some tweaks ) up to Test-TCP.
  • Test-TCP will wait for b.g.o #515270
  • After Test-TCP is updated in Gentoo, I'll start on pulling the rest.

@kentfredric
Copy link
Member

@kentfredric
Copy link
Member

Package-Manager: portage-2.2.10
Package-Manager: portage-2.2.10
Package-Manager: portage-2.2.10
Package-Manager: portage-2.2.10
Package-Manager: portage-2.2.10
Package-Manager: portage-2.2.10
Package-Manager: portage-2.2.10
@akreal
Copy link
Contributor Author

akreal commented Jun 30, 2014

Thank you for opening bump requests, will bother myself with it next time when need an updated module in the tree.
I played with git rebase and removed Test-TCP, Email-Abstract, Email-Sender commits, hope this doesn't break anything.

@kentfredric
Copy link
Member

Nope. =) . I encourage rebase as much as possible, I just don't always know who can and can't respond to requests to rebase. For instance, those two "fixup" commits at then end of your pull req would be better merged into a single commit.

Package-Manager: portage-2.2.10
@akreal
Copy link
Contributor Author

akreal commented Jun 30, 2014

Merged them both into original ebuild commit.

@kentfredric kentfredric merged commit 0b706b8 into gentoo-perl:master Sep 13, 2014
kentfredric added a commit that referenced this pull request Sep 13, 2014
Merge commit '0b706b8'

* commit '0b706b8':
  [added] Dancer2-Plugin-Paginator-1.0.0
  [added] dev-perl/Paginator-Lite-2.0.7
  [added] dev-perl/Dancer2-Plugin-Emailesque-0.20.0
  [added] dev-perl/Emailesque-1.200.7
  [added] dev-perl/Email-Stuffer-0.9.0
  [added] dev-perl/Email-AddressParser-0.40.0
  [added] dev-perl/Dancer2-Plugin-Auth-Tiny-0.3.0
  [added] dev-perl/Dancer2-Session-Cookie-0.5.0
@kentfredric
Copy link
Member

Sorry for taking so long to merge this. I also had to go through and touch up and commit --amend a few commits due to how the manifest system has changed.

@akreal
Copy link
Contributor Author

akreal commented Sep 13, 2014

No problem, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants