Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev-python/bokeh: version bump #352

Merged
merged 7 commits into from Jan 23, 2015
Merged

dev-python/bokeh: version bump #352

merged 7 commits into from Jan 23, 2015

Conversation

marbre
Copy link
Contributor

@marbre marbre commented Jan 20, 2015

The commits add a version bumped ebuild for bokeh to the overlay.

I applied the diff of #529986, but adjusted the required use flag of net-libs/nodejs and added additional dies. I further ported the setup.patch from version 0.5.0 to 0.7.1.

This ebuild definitely needs some review. Every assistance is welcome.

@@ -0,0 +1,10 @@
--- setup.py 2015-01-12 19:37:38.000000000 +0100
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please write a header, why this is needed, also see http://dev.gentoo.org/~vapier/clean-patches!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I wasn't aware of that and actually nearly no of the patches if looked into so far come with a header. I will do this the other patches (other ebuilds) I pushed so far too.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is always something new to learn ;-)

@marbre
Copy link
Contributor Author

marbre commented Jan 22, 2015

Adding phantomjs to RDEPEND was sufficient.

python_prepare_all() {
# https://github.com/bokeh/bokeh/issues/1352
sed -e "s: 'bokeh.mplexporter',:&\n 'bokeh.mplexporter.renderers',:" \
-i setup.py || die
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for checking, didn't find the time so far. Fixed.


pkg_postinst() {
elog "websockets work only with python2_7"
local chaco_msg="chaco useflag doesn't affect python targets other than python2_7"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess, also this chaco stuff here can be removed, too.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, didn't checked this well enough, sorry. Fixed.

junghans added a commit that referenced this pull request Jan 23, 2015
dev-python/bokeh: version bump
@junghans junghans merged commit ba10fc1 into gentoo:master Jan 23, 2015
@marbre marbre deleted the bokeh branch January 23, 2015 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants