Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

repositories: Add escpr2-overlay #662364 #371

Closed
wants to merge 1 commit into from
Closed

repositories: Add escpr2-overlay #662364 #371

wants to merge 1 commit into from

Conversation

andreas-thalhammer
Copy link
Contributor

https://bugs.gentoo.org/662364
Since I'm investing time in keeping the repo current, it would be nice if it was added to the official repositories list.
Thanks.

@mgorny
Copy link
Member

mgorny commented Feb 15, 2021

The second line of your repo_name seems to be relying on undefined behavior.

@andreas-thalhammer
Copy link
Contributor Author

The second line of your repo_name seems to be relying on undefined behavior.

Fixed. In the documentation it somewhere stated that only the first line would be used, so that is the defined behaviour. I thought I'd use the second line to write the full repo's name. But I removed it now.

@mgorny
Copy link
Member

mgorny commented Feb 15, 2021

The second line of your repo_name seems to be relying on undefined behavior.

Fixed. In the documentation it somewhere stated that only the first line would be used, so that is the defined behaviour. I thought I'd use the second line to write the full repo's name. But I removed it now.

See: https://dev.gentoo.org/~ulm/pms/head/pms.html

repo_name
Contains, on a single line, the name of this repository. [...]

I'm pretty sure that there are tools that rely on cat profiles/repo_name returning just that ;-).

@andreas-thalhammer
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants