ebuild-writing/misc-files/patches: discourage commenting out lines #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ulm
reviewed
Apr 10, 2021
* Drop dates as we now recommend * Use patch level 1 Signed-off-by: Sam James <sam@gentoo.org>
…patch content We shouldn't add comments (#) within patch changes to source code (etc) because it's unnecessary noise. Comments *at the top* of the patch are, of course, welcoome. Signed-off-by: Sam James <sam@gentoo.org>
thesamesam
force-pushed
the
patches-no-comments
branch
from
4871fa7
to
a03a0af
Compare
ulm
reviewed
Jun 18, 2021
| @@ -293,6 +293,14 @@ files automatically. Alternatively, you can specify the <c>-E</c> option with | |||
| <c>eapply</c> if you want to remove an empty file. | |||
| </p> | |||
|
|
|||
| <p> | |||
| Removed lines should not appear in the patch because they are commented <d/> just | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We shouldn't add comments (#) within patch changes to source code (etc) because
it's unnecessary noise. Comments at the top of the patch are, of course, welcoome.