Make ewarn and eerror log to stderr #4
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fix the handling of EINFO_QUIET and EERROR_QUIET. This should resolve bug 548158.
| else | ||
| if ! yesno "${RC_ENDCOL}" && [ "${LAST_E_CMD}" = "ebegin" ]; then | ||
| printf "\n" | ||
| printf "\n" >&2 |
There was a problem hiding this comment.
Pretty nit-picky but I wonder if this newline should stay on stdout since its purpose is to complete the message that ebegin wrote. That would adding && ! yesno "${EINFO_QUIET}" to the condition.
There was a problem hiding this comment.
Yeah, libeinfo seems to do something entirely different, so I have no basis for how this should work.
There was a problem hiding this comment.
After reading libeinfo a bit more, it looks like this newline would be written to stderr. I have confirmed this using strace.
So my code matches the behavior of the existing openrc code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fix the handling of EINFO_QUIET and EERROR_QUIET.
This should resolve bug 548158.