Added new dependency to CGO usb bindings #105
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Commit for dev-libs/go-usb package. Please review. |
…fs compile properly
|
Please leave comment on the bug when you submit a PR, so the assignee knows about it :P. |
| src_test() { | ||
| go test -ldflags '-extldflags=-fno-PIC' ${GO_PN} || die | ||
| } | ||
|
|
There was a problem hiding this comment.
I'll fix this and those below during the week. Sorry for late reply, it seems i wasn't getting these email notifications.
| @@ -46,7 +46,7 @@ done | |||
|
|
|||
| insinto /usr/lib/go/ | |||
| doins -r "${S}/pkg" | |||
| insinto "/usr/lib/go/src/pkg/${GO_PN}/" | |||
| insinto "/usr/lib/go/src/${GO_PN}/" | |||
There was a problem hiding this comment.
I've pinged go-fuse maintainer about this.
… since I can't reproduce why I used it in the first place.
|
@ZeroChaos- see my last commit, i removed the added get_libdir and doins loop since it's not even necessary. |
|
still approved |
|
Ok, checked this and go itself uses /usr/lib. |
|
|
||
| src_install() { | ||
| insinto "${GO_PN}" | ||
| doins *.go LICENSE || die "Install failed" |
There was a problem hiding this comment.
die unnecessary in EAPI 5 (with doins).
|
Ok, I'm going to fix that tiny bug and merge it. |
|
All merged now. Closing. |
minaco2
pushed a commit
to git-portage/git-portage
that referenced
this pull request
May 12, 2015
… Part of gentoo/gentoo-portage-rsync-mirror#105 by likewhoa. (Portage version: 2.2.18/cvs/Linux x86_64, signed Manifest commit with key EFB4464E!)
minaco2
pushed a commit
to git-portage/git-portage
that referenced
this pull request
May 12, 2015
…t of gentoo/gentoo-portage-rsync-mirror#105 by likewhoa. (Portage version: 2.2.18/cvs/Linux x86_64, signed Manifest commit with key EFB4464E!)
minaco2
pushed a commit
to git-portage/git-portage
that referenced
this pull request
May 12, 2015
…t of gentoo/gentoo-portage-rsync-mirror#105 by likewhoa. (Portage version: 2.2.18/cvs/Linux x86_64, signed Manifest commit with key EFB4464E!)
minaco2
pushed a commit
to git-portage/git-portage
that referenced
this pull request
May 12, 2015
…e-rsync-mirror#105 by likewhoa. (Portage version: 2.2.18/cvs/Linux x86_64, signed Manifest commit with key EFB4464E!)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in relation to bug 547204 at b.g.o which bug 523990 needs in order to properly compile. I will send another PR and reference it which will contain the ebuild for dev-libs/go-usb