net-analyzer/speedtest-cli - add setuptools dependency (bug# 502302) #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,4 +1,4 @@ | |||
| # Copyright 1999-2015 Gentoo Foundation | |||
| # Copyright 1998-2015 Gentoo Foundation | |||
There was a problem hiding this comment.
Please don't move copyright back :).
|
Please fix the copyright year and then I'll merge it. |
|
Merged. Now a quick extra lesson: in trivial-yet-important fixes like this, you may consider adding them to older stable version too. I just did that after confirming it uses setuptools as way. While you generally should be extra cautious when dealing with stable ebuilds, adding extra |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This annoyed me for quite some time. Especially on minimal systems, were setuptools wasn't pulled by any other packages, i've hit this quite often. Would be nice if we could finally add this dependency.
Gentoo-Bug: https://bugs.gentoo.org/show_bug.cgi?id=502302
Btw, the bug is for Version 0.2.4, but it's still valid for 0.2.5 - just testet it + see duplicate.
Maybe this should also block: https://bugs.gentoo.org/show_bug.cgi?id=530994