Improvements to the nodejs 0.12.2 ebuild #118
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There are still issues with https://bugs.gentoo.org/show_bug.cgi?id=541656 for prefix, see my comment. |
|
@jbergstroem, it looks that patrick has added -r2 with some random changes. Could you take a look and update the PR? |
Most of these changes are adopted from iojs, but since nodejs hasn't evolved the same way as iojs (both build system and src), a lot of stuff is held back. This is intentional from an ebuild point of view as well to treat nodejs 0.x as stable builds forward. This intends to fix the following bugs: - https://bugs.gentoo.org/show_bug.cgi?id=542970 - https://bugs.gentoo.org/show_bug.cgi?id=539342 - https://bugs.gentoo.org/show_bug.cgi?id=539314 - https://bugs.gentoo.org/show_bug.cgi?id=540766 - https://bugs.gentoo.org/show_bug.cgi?id=541656 - https://bugs.gentoo.org/show_bug.cgi?id=462703 - https://bugs.gentoo.org/show_bug.cgi?id=540106 - (pending confirm) https://bugs.gentoo.org/show_bug.cgi?id=533176
|
Ok - he committed the first version. Rebased this patchset onto master -- recommending -r3 to fix the prefix install 🎉 |
|
After that's been cut we should also close all referenced bugs. |
|
https://bugs.gentoo.org/show_bug.cgi?id=539314 is pengupop stablereq :P. |
|
Ok, merged as -r3 and closed all mentioned bugs. Though you may want to check whether 539314 didn't mean something else :P. |
minaco2
pushed a commit
to git-portage/git-portage
that referenced
this pull request
May 14, 2015
… by jbergstroem. (Portage version: 2.2.18/cvs/Linux x86_64, signed Manifest commit with key EFB4464E!)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of these changes are adopted from iojs, but since nodejs hasn't evolved the same way as iojs (both build system and src), a lot of stuff is held back. This is intentional from an ebuild point of view as well to treat nodejs 0.x as stable builds forward.
This intends to fix the following bugs: