New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
version bump: dev-libs/hiredis 0.13.1 #136
version bump: dev-libs/hiredis 0.13.1 #136
Conversation
Not sure about returning 0/1 vs die in src_test. Would appreciate some feedback on improving that as well. |
Also, how do we handle the dep to dev-db/redis for the other arches? |
bringing @neurogeek (maintainer) in here. |
ping @mgorny |
static void test_blocking_connection_errors(void) { | ||
redisContext *c; | ||
|
||
+ /* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Safer to do #if 0
. Won't break on comments in the middle of it :).
So, how do we handle KEYWORDS between hiredis and redis? |
Well, obviously you drop the keywords that are not on redis. |
Now, if you really believe someone used hiredis on those arches, we need a new keywordreq for both packages. |
@mgorny ..or expand dev-db/redis? I can't vouch wider than x86/amd64. Keywords seems to been around for a while (besides alpha) so it'd be great to get @neurogeek's opinion. |
Just added an attempt to fix the paths in the pkg-config file. I feel like it isn't quite enough though;
|
I guess you'd pass |
Just to be clear, if you're not sure about Prefix support, you can leave it out. Prefix is pretty much 'if we can, we do it, if we can't, we leave it to prefix@ to fix :)'. |
local REDIS_PID="${T}"/hiredis.pid | ||
local REDIS_SOCK="${T}"/hiredis.sock | ||
local REDIS_PORT=56379 | ||
local REDIS_TEST_CONFIG=$"daemonize yes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, $""
implies parsing escapes like \n. If you don't use them anymore, use plain ""
:).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The config assumes each option is on a newline
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, but you don't need $""
for the inline newlines.
@jbergstroem, are you still there? Also you need to rebase :P. |
Copy from 0.11-r1
- don't return from src_test, die on retval instead - change how we pass config to redis
Rebased and fixed outstanding issues. |
Also:
Now you go file a keywordreq :). |
Bump including a few fixes and features.
question: does insinto/doins require ${ED}?