freebsd.eclass: Fix for FreeBSD10.0 or later #36
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-9999 ebuild, changed to use to force /usr/share/mk on FreeBSD 10.0. Fixed a problem of numerical comparison in 10.0.
| @@ -141,7 +147,8 @@ freebsd_src_unpack() { | |||
|
|
|||
| # Starting from FreeBSD 9.2, its install command supports the -l option and | |||
| # they now use it. Emulate it if we are on a system that does not have it. | |||
| if [[ ${RV} > 9.1 ]] && ! has_version '>=sys-freebsd/freebsd-ubin-9.2_beta1' ; then | |||
| version_compare ${RV} 9.1 | |||
There was a problem hiding this comment.
Please avoid version_compare since it's hard to read. Prefer ! version_is_at_least.
….1, 9.2, and 10.1.
|
@mgorny, Thank you for advice. I have updated the patch. The results of the test are as follows. |
|
minaco2
pushed a commit
to git-portage/git-portage
that referenced
this pull request
Feb 22, 2015
…ion comparison for install commands. gentoo/gentoo-portage-rsync-mirror#36 by nigoro.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-9999 ebuild, changed to use to force /usr/share/mk.
Fixed a problem of numerical comparison in 10.0.
Details please see
https://bugs.gentoo.org/show_bug.cgi?id=488214#c23
https://bugs.gentoo.org/show_bug.cgi?id=488214#c24